From owner-cvs-ports@FreeBSD.ORG  Thu Jun  2 19:49:42 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A7FDC1065673;
	Thu,  2 Jun 2011 19:49:42 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.49.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 5CFB28FC17;
	Thu,  2 Jun 2011 19:49:42 +0000 (UTC)
Received: by syn.atarininja.org (Postfix, from userid 1001)
	id C51F05C43; Thu,  2 Jun 2011 15:52:48 -0400 (EDT)
Date: Thu, 2 Jun 2011 15:52:48 -0400
From: Wesley Shields <wxs@FreeBSD.org>
To: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
Message-ID: <20110602195248.GA62894@atarininja.org>
References: <201106021631.p52GVgHM038132@repoman.freebsd.org>
	<20110602165708.GA61311@atarininja.org>
	<4DE7D4B4.3040302@yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4DE7D4B4.3040302@yandex.ru>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net/erlyvideo Makefile pkg-plist
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jun 2011 19:49:42 -0000

On Thu, Jun 02, 2011 at 10:21:40PM +0400, Ruslan Mahmatkhanov wrote:
> 02.06.2011 20:57, Wesley Shields ??????????:
> 
> >> | @@ -39,6 +40,7 @@ post-patch:
> >> |  		${WRKSRC}/priv/${PORTNAME}.conf.sample
> >> |  	@${FIND} ${WRKSRC} -type f -name .gitignore | ${XARGS} ${RM}
> >> |  	@${FIND} ${WRKSRC} -type f -name "*.bak" | ${XARGS} ${RM}
> >> | +	@${FIND} ${WRKSRC} -type f -name "*.orig" | ${XARGS} ${RM}
> >> |  	@${RMDIR} ${WRKSRC}/src/plugins
> >
> > I understand Ruslan was just following the convention used in this port
> > but I don't like this construct. We should at least be doing -print0 |
> > xargs -0 if we are going to be using xargs like this. I, personally,
> > would prefer us to use the -delete option to find.
> 
> I'm fully agree with that findelete stuff, so here is the patch,
> thanks for pointing out. Surely i picked this construct in some
> another port, but can't recall which one.

Thanks for taking care of this quickly. I will try and scour the tree in
the upcoming days to find more cases of this.

> >
> > I wonder if there are other places in the ports tree where a similar
> > construct can be found that we should also cleanup.
> >
> > -- WXS
> 
> There is plenty of ports that use `find | xargs rm/rmdir` construct.
> ros-*/rox-* ports for example.

Thanks for pointing these out!

-- WXS