From owner-cvs-all@FreeBSD.ORG Fri Feb 6 15:03:02 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2511716A4D1 for ; Fri, 6 Feb 2004 15:03:02 -0800 (PST) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DAAE43D31 for ; Fri, 6 Feb 2004 15:02:57 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 22287 invoked from network); 6 Feb 2004 23:02:56 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 6 Feb 2004 23:02:56 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i16N2pM0020942; Fri, 6 Feb 2004 18:02:52 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Tim Robbins Date: Fri, 6 Feb 2004 17:44:46 -0500 User-Agent: KMail/1.5.4 References: <200402061930.i16JUCpa011145@repoman.freebsd.org> <20040206221255.GA54490@cat.robbins.dropbear.id.au> In-Reply-To: <20040206221255.GA54490@cat.robbins.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200402061744.46011.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_resource.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2004 23:03:02 -0000 On Friday 06 February 2004 05:12 pm, Tim Robbins wrote: > On Fri, Feb 06, 2004 at 11:30:12AM -0800, John Baldwin wrote: > > jhb 2004/02/06 11:30:12 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_resource.c > > Log: > > - Correct the translation of old rlimit values to properly handle the > > old RLIM_INFINITY case for ogetrlimit(). > > - Use %jd and intmax_t to output negative time in usec in calcru(). > > - Rework getrusage() to make a copy of the rusage struct into a local > > variable while holding Giant and then do the copyout from the local > > variable to avoid having to have the original process rusage struct > > locked while doing the copyout (which would not be safe). This also > > includes a few style fixes from Bruce to getrusage(). > > Thanks (from the one who added the XXX comment). Can't we use the > proc lock here though? No idea. Haven't looked at doing the p_stats locking or p_cru locking yet. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org