From owner-cvs-src@FreeBSD.ORG  Thu Nov 18 04:56:46 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C1F8916A4CE
	for <cvs-src@FreeBSD.org>; Thu, 18 Nov 2004 04:56:46 +0000 (GMT)
Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3D81643D2D
	for <cvs-src@FreeBSD.org>; Thu, 18 Nov 2004 04:56:44 +0000 (GMT)
	(envelope-from jmg@hydrogen.funkthat.com)
Received: (qmail 14339 invoked from network); 18 Nov 2004 04:56:43 -0000
Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168])
          (envelope-sender <jmg@hydrogen.funkthat.com>)
          by mail1.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <ru@FreeBSD.org>; 18 Nov 2004 04:56:43 -0000
Received: from hydrogen.funkthat.com (hktgbs@localhost.funkthat.com
	[127.0.0.1])iAI4uhB6048720;	Wed, 17 Nov 2004 20:56:43 -0800 (PST)
	(envelope-from jmg@hydrogen.funkthat.com)
Received: (from jmg@localhost)
	by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id iAI4ugIf048719;
	Wed, 17 Nov 2004 20:56:42 -0800 (PST)
Date: Wed, 17 Nov 2004 20:56:42 -0800
From: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
To: Ruslan Ermilov <ru@FreeBSD.org>
Message-ID: <20041118045642.GS57546@funkthat.com>
References: <200411172135.iAHLZNfR098453@repoman.freebsd.org>
	<20041117224336.GC1562@ip.net.ua>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041117224336.GC1562@ip.net.ua>
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD 4.2-RELEASE i386
X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31  96 7A 22 B3 D8 56 36 F4
X-Files: The truth is out there
X-URL: http://resnet.uoregon.edu/~gurney_j/
X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Bruce Evans <bde@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/pci if_sk.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Nov 2004 04:56:47 -0000

Ruslan Ermilov wrote this message on Thu, Nov 18, 2004 at 00:43 +0200:
> My old patch (that I didn't commit due to the lack of h/w),
> resets IFF_OACTIVE inside the while() loop, like this:
> 
>                 sc_if->sk_cdata.sk_tx_cnt--;
> +               ifp->if_flags &= ~IFF_OACTIVE;
>                 SK_INC(idx, SK_TX_RING_CNT);
> 
> I believe this is more correct than what got committed,
> but I cannot prove it.  ;)

considering that we hold the lock over the while loop, and then call
sk_start before the lock gets unlocked... :)

I have a similar patch for if_re that I need to try out...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."