From owner-svn-src-all@FreeBSD.ORG Mon Jan 2 05:21:09 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 715AB1065676; Mon, 2 Jan 2012 05:21:09 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id E92138FC08; Mon, 2 Jan 2012 05:21:08 +0000 (UTC) Received: by ghrr16 with SMTP id r16so6234356ghr.13 for ; Sun, 01 Jan 2012 21:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=+sRKxrGAArqnj/00FoYJv65tQKDIOFz6Bow18VmZidI=; b=ERtOOS1RsuYirU86CKF1yeK6HjO09DfkMOR7W5SrAv+HxTJ2YUjoDUzpV+/DjzvaDU KJYtdxRwUtSU+n6zeB562NGeJlGWGX4uVQlpzsDrj3lUA0q7vNBuwHx8Bix/snjXZMHu S6x1YEplnMQyV3+WyLTNQiFWuINS1FrOG5g1U= MIME-Version: 1.0 Received: by 10.236.173.234 with SMTP id v70mr10917903yhl.32.1325481668277; Sun, 01 Jan 2012 21:21:08 -0800 (PST) Received: by 10.236.110.40 with HTTP; Sun, 1 Jan 2012 21:21:08 -0800 (PST) In-Reply-To: <20120101173342.GN83814@acme.spoerlein.net> References: <201112301058.pBUAwFsw010478@svn.freebsd.org> <20120101173342.GN83814@acme.spoerlein.net> Date: Mon, 2 Jan 2012 00:21:08 -0500 Message-ID: From: Ben Kaduk To: Ulrich Spoerlein , Ben Kaduk , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnmp... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2012 05:21:09 -0000 On Sun, Jan 1, 2012 at 12:33 PM, Ulrich Spoerlein wrote: > On Fri, 2011-12-30 at 14:43:22 -0500, Ben Kaduk wrote: >> On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein wrot= e: >> > Modified: head/usr.sbin/cron/doc/CHANGES >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >> > --- head/usr.sbin/cron/doc/CHANGES =A0 =A0 =A0Fri Dec 30 10:45:00 2011= =A0 =A0 =A0 =A0(r228989) >> > +++ head/usr.sbin/cron/doc/CHANGES =A0 =A0 =A0Fri Dec 30 10:58:14 2011= =A0 =A0 =A0 =A0(r228990) >> > @@ -1,3 +1,6 @@ >> > +$FreeBSD$ >> > +-------- >> > + >> > =A0Vixie Cron =A0 =A0 =A0 =A0 =A0 =A0 Changes from V2 to V3 >> > =A0Paul Vixie >> > =A029-Dec-1993 >> > @@ -20,7 +23,7 @@ be reread whenever it changes. >> > >> > =A0I also added a "-e" option to crontab(1). =A0Nine people also sent = me diffs >> > =A0to add this option, but I had already implemented it on my own. =A0= I actually >> > -released an interrim version (V2.2, I think) for limited testing, and= got a >> > +released an interim version (V2.2, I think) for limited testing, and = got a >> >> Should we really be in the business of modifying Vixie's changelog? > > I'm replying here, but same goes for your comments on the other revision > (thanks for all those, btw). > > Warning, rant ahead: I can handle a rant :) > > Our current SVN repo is in an inconsistent state thanks to the dubious > introduction of svn keywords. There are files in there, converted over > via cvs2svn and never touched since, but our presubmit checks want to > either see a $FreeBSD$ tag in modified files, or have fbsd:nokeywords > set. The latter is kinda a no-brainer for everything under contrib/ but > I'm struggling with what to do exactly for files that are non-contrib > and may or may not be non-code. Should the keywords be set on $subdir/* > or can I punch holes in the web of keywords as I see fit? (e.g. > $subdir/{README,CHANGES,foo.txt}) > > What's the point then anyway? SVN doesn't track files, but changesets. > Gah! I guess I did assume that the $FreeBSD$ keyword was being added because of the presubmit checks, but didn't actually say so. Sorry. It definitely is a grey area in which I don't presume to have an opinion, and I sympathize with your frustration. > > Oh wait, this ain't about the $FreeBSD$ keyword, but the typo-fix? I'm > sure that Vixie won't mind and do believe that correctness of spelling > is a worthy goal as we always tout the quality of our documentation. > I can accept that argument -- I mostly wanted to make sure this wasn't just a mechanical "run aspell over everything" or similar (though a later change did reveal that to not be the case). > FWIW, I'm not going to touch stuff under contrib/, etc. Sounds fine. > >> > =A0/* >> > - * Delete a rotated logfiles, when using clasic filenames. >> > + * Delete a rotated logfiles, when using classic filenames. >> >> "a logfiles" is inconsistent. =A0Without looking up the implementation, >> I'm going to guess that "a rotated logfile" is correct. > > When proofreading the spell-checked output I focused too narrowly on > just the typo that I fixed so that other typos in the same line/sentence > mostly went unnoticed. Will do better in the next couple of commits. It's easy to do -- I actually found myself also doing so a couple times when going through these. (There were quite a number of them, and thanks for going through them all by hand!) -Ben Kaduk