From owner-cvs-src@FreeBSD.ORG Fri Apr 11 06:15:34 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 037C2106564A; Fri, 11 Apr 2008 06:15:34 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.70]) by mx1.freebsd.org (Postfix) with ESMTP id DFF218FC14; Fri, 11 Apr 2008 06:15:33 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from mac.com (asmtp003-s [10.150.69.66]) by smtpoutm.mac.com (Xserve/smtpout007/MantshX 4.0) with ESMTP id m3B6FX4f027852; Thu, 10 Apr 2008 23:15:33 -0700 (PDT) Received: from [192.168.1.100] (209-128-86-226.bayarea.net [209.128.86.226]) (authenticated bits=0) by mac.com (Xserve/asmtp003/MantshX 4.0) with ESMTP id m3B6FVSw012128 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 10 Apr 2008 23:15:32 -0700 (PDT) Message-Id: <9B8DD956-E197-4540-A7F3-367B1E277456@mac.com> From: Marcel Moolenaar To: Jeff Roberson In-Reply-To: <20080410190028.U43186@desktop> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Date: Thu, 10 Apr 2008 23:15:31 -0700 References: <200804110326.m3B3QfjL095474@repoman.freebsd.org> <20080410190028.U43186@desktop> X-Mailer: Apple Mail (2.919.2) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_cpuset.c kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2008 06:15:34 -0000 On Apr 10, 2008, at 10:01 PM, Jeff Roberson wrote: > On Thu, 10 Apr 2008, Marcel Moolenaar wrote: > >> >> On Apr 10, 2008, at 8:26 PM, Jeff Roberson wrote: >>> jeff 2008-04-11 03:26:41 UTC >>> FreeBSD src repository >>> Modified files: >>> sys/amd64/amd64 intr_machdep.c >>> sys/arm/arm intr.c >>> sys/i386/i386 intr_machdep.c >>> sys/ia64/ia64 interrupt.c >>> sys/kern kern_cpuset.c kern_intr.c >>> sys/powerpc/powerpc intr_machdep.c >>> sys/sparc64/sparc64 intr_machdep.c >>> sys/sun4v/sun4v intr_machdep.c >>> sys/sys cpuset.h interrupt.h >>> Log: >>> - Add the interrupt vector number to intr_event_create so MI code >>> can >>> lookup hard interrupt events by number. Ignore the irq# for >>> soft intrs. >> >> JFYI: vectors are not the same as hard interrupt numbers. >> On ia64 they imply priority, which means that vector >> numbers should be selected for their priority and not >> have a 1-to-1 mapping with IRQ number. >> On powerpc they mean absolutely nothing other than being >> an index into an array. >> >> It's better to use IRQs and not vectors to lookup int. >> events by number. > > I think I mixed my terminology in the commit. I meant for all > architectures to pass in the number that would appear in vmstat -i. > Can you verify that this is what I did for powerpc and ia64? powerpc correctly uses irq. ia64 incorrectly uses vector. Would you mind changing ia64 to use irq as well? Thanks, -- Marcel Moolenaar xcllnt@mac.com