From owner-freebsd-rc@FreeBSD.ORG Mon Feb 6 21:48:54 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 266961065670 for ; Mon, 6 Feb 2012 21:48:54 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id 1AFCD8FC12 for ; Mon, 6 Feb 2012 21:48:52 +0000 (UTC) Received: from alph.allbsd.org (p1012-ipbf2105funabasi.chiba.ocn.ne.jp [114.148.160.12]) (authenticated bits=128) by mail.allbsd.org (8.14.4/8.14.4) with ESMTP id q16LmRZ9039505; Tue, 7 Feb 2012 06:48:37 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.allbsd.org (8.14.4/8.14.4) with ESMTP id q16LmPZf009200; Tue, 7 Feb 2012 06:48:27 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Tue, 07 Feb 2012 06:47:01 +0900 (JST) Message-Id: <20120207.064701.1809281571072237708.hrs@allbsd.org> To: erdgeist@erdgeist.org From: Hiroki Sato In-Reply-To: <4F2F442F.3030509@erdgeist.org> References: <4F2F3459.3090401@erdgeist.org> <20120206.114622.2214566196455293098.hrs@allbsd.org> <4F2F442F.3030509@erdgeist.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Tue_Feb__7_06_47_01_2012_164)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [133.31.130.32]); Tue, 07 Feb 2012 06:48:42 +0900 (JST) X-Spam-Status: No, score=-100.8 required=13.0 tests=BAYES_00, CONTENT_TYPE_PRESENT,RCVD_IN_PBL,RCVD_IN_RP_RNBL,SPF_SOFTFAIL, USER_IN_WHITELIST autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org Subject: Re: Proposal ipv6_addrs_common X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2012 21:48:54 -0000 ----Security_Multipart(Tue_Feb__7_06_47_01_2012_164)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Dirk Engling wrote in <4F2F442F.3030509@erdgeist.org>: er> The bugs in /etc/network.subr, function ifalias_up I would like to see er> fixed, anyway: er> er> _ret=`ifalias_ipv4_up "$1"` er> er> just does not work the way you imagined it. The return code is not er> passed when using _ret=`` but the command substituted by it's output er> on stdout, it should read: er> er> ifalias_ipv4_up ${_if} && _ret=0 er> er> as shown in my patch. Thanks for the report. I will take a look into it. er> > In my patch IPv6-mapped IPv4 address is not supported, but your er> > patch can be merged easily. er> er> I like the idea of configuring a router or DNS server for several er> subnets with one range as well, i.e. "inet 10.8.2-16.1/24", do you er> think this makes sense? Sounds good to me. er> > One thing in my mind is whether allowing a variable which contains er> > multiple lines is reasonable or not. er> er> I do not understand the problem there, does your code actually DEPEND er> on new lines? If not, it's just a matter of taste how to arrange your er> variables in your rc.conf, if it doesn't fit in 80 chars, you can er> either overflow, add backslashes or use the style above. The rc's er> author does not FORCE the user into one style, does he? It actually depends on the newline because the following code is used: --- foo=" foo bar baz " echo "$foo" | while read L; do echo $L; done --- -- Hiroki ----Security_Multipart(Tue_Feb__7_06_47_01_2012_164)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk8wSlUACgkQTyzT2CeTzy23WQCeIple7SFNeBRL/iuPV/sppalA lXYAoJLtfPvoRYs1TTo06mSLyf1GJPYv =WNrT -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Feb__7_06_47_01_2012_164)----