From owner-cvs-all@FreeBSD.ORG Mon Oct 18 19:24:36 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD7BC16A4CE; Mon, 18 Oct 2004 19:24:35 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id C614343D49; Mon, 18 Oct 2004 19:24:34 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IJOXJ8002635; Mon, 18 Oct 2004 22:24:33 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 42838-10; Mon, 18 Oct 2004 22:24:32 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IJOPUS002629; Mon, 18 Oct 2004 22:24:28 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9IJOInd000879; Mon, 18 Oct 2004 22:24:18 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 22:24:17 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20041018192417.GE89681@ip.net.ua> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> <20041018190044.GA89411@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BZaMRJmqxGScZ8Mx" Content-Disposition: inline In-Reply-To: <20041018190044.GA89411@hub.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 19:24:36 -0000 --BZaMRJmqxGScZ8Mx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 07:00:47PM +0000, David O'Brien wrote: > On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote: > > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > > > > obrien 2004-10-18 17:19:36 UTC > > > > > FreeBSD src repository > > > > > Modified files: > > > > > lib/libc/i386/net htonl.S ntohl.S=20 > > > > > Log: > > > > > Sync with sys/i386/include/endian.h: use the single instruction= 'bswap'. > .. > > > I know. Give me some other symbol then we can publish that one should > > > add to /etc/make.conf CFLAGS to try to build a userland for an I386. > > > "I386_CPU" looks as good a spelling as any and I didn't see any need = to > > > spell it differently than in the kernel. > > >=20 > > You can check for the CPUTYPE=3D"i386" for ${MACHINE_ARCH} =3D=3D "i386" > > in libc/Makefile, and set I386_CPU in CFLAGS in this case. >=20 > Taking=20 > Revision Changes Path > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S >=20 > specifically what patch do you suggest that we used in cases like this > rather than #ifdef I386_CPU". And how to use it? That is one in which > someone checks out the source and wants to build a userland that is > usable on an I386 machine. >=20 I thought I already made it clear, seems not. In src/lib/Makefile, add this: =2Eif ${MACHINE_ARCH} =3D=3D "i386" && defined(CPUTYPE) && ${CPUTYPE} =3D= =3D "i386" CFLAGS+=3D -DI386_CPU =2Eendif Or maybe even add -DI386_CPU to _CPUCFLAGS globally in bsd.cpu.mk, so it can be used anywhere. Note: this is completely untested! Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --BZaMRJmqxGScZ8Mx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBdBhhqRfpzJluFF4RArLJAJ969hENApKkGQ1ombX6DumYZEbznACfegei j4xD91a3FlTmqtCIj0CqNU4= =tnkv -----END PGP SIGNATURE----- --BZaMRJmqxGScZ8Mx--