From owner-freebsd-bugs@FreeBSD.ORG Mon Aug 25 00:40:16 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B1A216A4BF for ; Mon, 25 Aug 2003 00:40:16 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52A0D43FBF for ; Mon, 25 Aug 2003 00:40:15 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7P7eFUp099894 for ; Mon, 25 Aug 2003 00:40:15 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7P7eFc4099893; Mon, 25 Aug 2003 00:40:15 -0700 (PDT) Resent-Date: Mon, 25 Aug 2003 00:40:15 -0700 (PDT) Resent-Message-Id: <200308250740.h7P7eFc4099893@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andre Albsmeier Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B792116A4EA for ; Mon, 25 Aug 2003 00:39:13 -0700 (PDT) Received: from david.siemens.de (david.siemens.de [192.35.17.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5109543FB1 for ; Mon, 25 Aug 2003 00:39:12 -0700 (PDT) (envelope-from andre.albsmeier@siemens.com) Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by david.siemens.de (8.11.7/8.11.7) with ESMTP id h7P7dAH13804 for ; Mon, 25 Aug 2003 09:39:11 +0200 (MEST) Received: from mars.cert.siemens.de (ust.mchp.siemens.de [139.23.201.17]) by mail3.siemens.de (8.11.7/8.11.7) with ESMTP id h7P7dAG25879 for ; Mon, 25 Aug 2003 09:39:10 +0200 (MEST) Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.42.7]) 1.46 2003/05/28 09:28:32 ust Exp $) with ESMTP id h7P7dAY5035098 for ; Mon, 25 Aug 2003 09:39:10 +0200 (CEST) Received: (from localhost) by curry.mchp.siemens.de (8.12.9/8.12.9) id h7P7dAKb072379 for FreeBSD-gnats-submit@freebsd.org; Mon, 25 Aug 2003 09:39:10 +0200 (CEST) Message-Id: <200308250739.h7P7dASD003261@curry.mchp.siemens.de> Date: Mon, 25 Aug 2003 09:39:10 +0200 (CEST) From: Andre Albsmeier To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/55950: [PATCH] fetch -ds dumps core on ftp URLs X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2003 07:40:16 -0000 >Number: 55950 >Category: bin >Synopsis: [PATCH] fetch -ds dumps core on ftp URLs >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 25 00:40:14 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Andre Albsmeier >Release: FreeBSD 4.8-STABLE i386 >Organization: >Environment: System: FreeBSD 4.8-STABLE #0: Tue Aug 12 09:17:59 CEST 2003 >Description: fetch does a coredump when getting invoked with -ds on ftp URLs. The bug was introduced with 1.16.2.31 of ftp.c. >How-To-Repeat: andre@gate:~>fetch -ds ftp://ftp.freebsd.org/pub/FreeBSD/README.TXT zsh: 13731 segmentation fault (core dumped) fetch -ds ftp://ftp.freebsd.org/pub/FreeBSD/README.TXT >Fix: in lib/libfetch/ftp.c we have: /* just a stat */ if (strcmp(op, "STAT") == 0) return (FILE *)1; /* bogus return value */ if (strcmp(op, "STOR") == 0 || strcmp(op, "APPE") == 0) so the fix is: --- lib/libfetch/ftp.c.ORI Tue Jun 10 08:54:16 2003 +++ lib/libfetch/ftp.c Mon Aug 25 08:15:06 2003 @@ -1006,7 +1006,7 @@ f = _ftp_request(url, "STAT", us, _ftp_get_proxy(flags), flags); if (f == NULL) return (-1); - fclose(f); + /* no need to close the file since the pointer is bogus anyway */ return (0); } >Release-Note: >Audit-Trail: >Unformatted: