From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 6 13:40:08 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F1CE10656A9 for ; Mon, 6 Sep 2010 13:40:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3F54C8FC27 for ; Mon, 6 Sep 2010 13:40:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o86De8ga072353 for ; Mon, 6 Sep 2010 13:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o86De8bG072344; Mon, 6 Sep 2010 13:40:08 GMT (envelope-from gnats) Resent-Date: Mon, 6 Sep 2010 13:40:08 GMT Resent-Message-Id: <201009061340.o86De8bG072344@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Lapo Luchini Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DD9410656DB for ; Mon, 6 Sep 2010 13:36:42 +0000 (UTC) (envelope-from lapo@lapo.it) Received: from andxor.it (relay.andxor.it [195.223.2.3]) by mx1.freebsd.org (Postfix) with SMTP id 6F33C8FC19 for ; Mon, 6 Sep 2010 13:36:40 +0000 (UTC) Received: (qmail 45314 invoked from network); 6 Sep 2010 13:36:38 -0000 Received: from unknown (HELO lapo.andxor.it) (192.168.2.22) by andxor.it with SMTP; 6 Sep 2010 13:36:38 -0000 Received: from lapo.andxor.it (localhost.andxor.it [127.0.0.1]) by lapo.andxor.it (8.14.4/8.14.4) with ESMTP id o86DactL067413; Mon, 6 Sep 2010 15:36:38 +0200 (CEST) (envelope-from lapo@lapo.andxor.it) Received: (from lapo@localhost) by lapo.andxor.it (8.14.4/8.14.4/Submit) id o86DacL4067412; Mon, 6 Sep 2010 15:36:38 +0200 (CEST) (envelope-from lapo) Message-Id: <201009061336.o86DacL4067412@lapo.andxor.it> Date: Mon, 6 Sep 2010 15:36:38 +0200 (CEST) From: Lapo Luchini To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Lapo Luchini , ale@FreeBSD.org, miwi@FreeBSD.org Subject: ports/150327: [PATCH] www/xpi-adblock: do not install XPI metadata X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Sep 2010 13:40:08 -0000 >Number: 150327 >Category: ports >Synopsis: [PATCH] www/xpi-adblock: do not install XPI metadata >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Sep 06 13:40:07 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Lapo Luchini >Release: FreeBSD 8.1-RELEASE amd64 >Organization: >Environment: System: FreeBSD lapo.andxor.it 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010 >Description: Avoid installing an XPI's META-INF directory, as it contain meta-data and not actual data needed by the extension. All of the XPIs I've seen having this directory use it to store digital signature data, which is checked on install (and thus has no need to be there for a system package); I don't know about any other data that is expected to fit in that directory, but by the very nature of it, it should all be meta-data relative to the XPI itself, not about the actual extension to be installed. Some ports that are (IMvHO unnecessarily) installing that directory include: www/xpi-adblock_plus www/xpi-flashgot www/xpi-joga www/xpi-noscript www/xpi-pdf_download (all maintained by either ale@ or miwi@). I propose to avoid installing that directory directly from Makefile.xpi, using the following patch or something similar. Port maintainer (miwi@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99 >How-To-Repeat: >Fix: --- xpi-adblock-0.5.3.043.patch begins here --- diff -ruN --exclude=CVS /usr/ports/www/xpi-adblock/Makefile.xpi /usr/home/lapo/ports/xpi-adblock/Makefile.xpi --- /usr/ports/www/xpi-adblock/Makefile.xpi 2009-12-14 15:39:12.000000000 +0100 +++ /usr/home/lapo/ports/xpi-adblock/Makefile.xpi 2010-09-06 15:19:01.000000000 +0200 @@ -188,6 +188,9 @@ ${LN} -sf $$_xpi $$_app ${_Q} ; } ; } .endif +post-extract: + @${RM} -rf ${WRKSRC}/META-INF + # Maintainer section xpi-gen: extract @${ECHO_CMD} -n 'XPI_ID=' --- xpi-adblock-0.5.3.043.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: