From owner-cvs-src@FreeBSD.ORG Wed Apr 21 23:43:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 7490116A4CE; Wed, 21 Apr 2004 23:43:25 -0700 (PDT) Received: from localhost (green@localhost [127.0.0.1]) by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i3M6hNph001564; Thu, 22 Apr 2004 02:43:24 -0400 (EDT) (envelope-from green@green.homeunix.org) Message-Id: <200404220643.i3M6hNph001564@green.homeunix.org> X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4 To: Darren Reed In-Reply-To: Message from Darren Reed <20040422051953.GA27025@hub.freebsd.org> From: Brian Fundakowski Feldman Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 22 Apr 2004 02:43:23 -0400 Sender: green@green.homeunix.org cc: Luigi Rizzo cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Colin Percival cc: Max Laier Subject: Re: cvs commit: src/sys/net radix.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2004 06:43:25 -0000 Darren Reed wrote: > On Thu, Apr 22, 2004 at 02:59:38AM +0000, Max Laier wrote: > > > In the end, if someone decides that the code needs to be restructured > > > for better performance in SMP hardware, then that's what'll happen and > > > changes like these will have little significance at that point in time. > > > > I don't think so. It's much easier to restructure code you can actually read > > and understand. And honest, when one sees the current radix code (etc.), the > > first thing that comes to mind is "run!". Same applies to IPv6/KAME-code, btw > > - and I didn't see anybody to work on the locking there and I know a reason > > why. > > Now now, don't be mean :) > > But don't forget that at least the way the radix code "was" had the > backing of a number of chapters in a book that explain(ed/s) it all > and so it has an advantage over IPv6/KAME... We're not Unix; we're FreeBSD+KAME+abazillionotherthings, and whatever advantages Stevens' historical Unix had in the way of book documentation, you can count on it being out of date when it comes to what the code actually looks like, whether Luigi is "cleaning it up" or not. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\