From owner-freebsd-current@FreeBSD.ORG Fri May 19 07:56:24 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 819E716A467; Fri, 19 May 2006 07:56:24 +0000 (UTC) (envelope-from Hartmut.Brandt@dlr.de) Received: from smtp-3.dlr.de (smtp-3.dlr.de [195.37.61.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5674C43D76; Fri, 19 May 2006 07:56:13 +0000 (GMT) (envelope-from Hartmut.Brandt@dlr.de) Received: from beagle.kn.op.dlr.de ([129.247.173.6]) by smtp-3.dlr.de over TLS secured channel with Microsoft SMTPSVC(6.0.3790.1830); Fri, 19 May 2006 09:56:12 +0200 Date: Fri, 19 May 2006 09:56:12 +0200 (CEST) From: Harti Brandt X-X-Sender: brandt_h@beagle.kn.op.dlr.de To: Ganbold In-Reply-To: <446D7741.10102@micom.mng.net> Message-ID: <20060519095344.P13833@beagle.kn.op.dlr.de> References: <446D7741.10102@micom.mng.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 19 May 2006 07:56:12.0328 (UTC) FILETIME=[B25A0280:01C67B19] Cc: freebsd-current@freebsd.org, Gleb Smirnoff Subject: Re: small patch for ngctl X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Harti Brandt List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2006 07:56:25 -0000 Hi, On Fri, 19 May 2006, Ganbold wrote: I did not yet look at your patch, but does it work with ngctl receiving unexpected messages? I remember we had something like this in the tree already, but it was backed out, because readline (or libedit, don't remember which one) waiting for input blocked receiving control messages, as far as I remember. harti G>I've made a small patch enhancement for ngctl to support commands history via G>up/down keys when ngctl works under interactive mode. G>It was tested on 7.0-CURRENT machine (FreeBSD 7.0-CURRENT #3: Tue May 16 G>19:17:48 ULAST 2006). G> G>I thought this feature might be useful for all. I hope my patch follows G>style(9) and it is made against CURRENT, it should also cleanly apply on G>RELENG_6. G> G>I saw a similar enhancement patch in PR G>http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/87352 which adds line edit and G>history support to ngctl(8) via libedit. G> G>My patch uses TERMIOS(4) structure which I thought more portable. Maybe I'm G>wrong. G> G>Please let me know if there is anything that I did wrong. G> G>thanks, G> G>Ganbold G> G> G>