From owner-freebsd-current@FreeBSD.ORG Tue Jun 15 20:01:51 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B1AC106564A; Tue, 15 Jun 2010 20:01:51 +0000 (UTC) (envelope-from alexbestms@uni-muenster.de) Received: from SECMAIL.UNI-MUENSTER.DE (SECMAIL.UNI-MUENSTER.DE [128.176.192.141]) by mx1.freebsd.org (Postfix) with ESMTP id 9ED7E8FC14; Tue, 15 Jun 2010 20:01:50 +0000 (UTC) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by SECMAIL.UNI-MUENSTER.DE (Postfix) with ESMTP id 7C90EBF403; Tue, 15 Jun 2010 22:01:47 +0200 (CEST) Received: by gyh20 with SMTP id 20so4540260gyh.13 for ; Tue, 15 Jun 2010 13:01:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.218.21 with SMTP id ho21mr3449906qcb.102.1276632104876; Tue, 15 Jun 2010 13:01:44 -0700 (PDT) Received: by 10.229.247.142 with HTTP; Tue, 15 Jun 2010 13:01:44 -0700 (PDT) In-Reply-To: References: <4C17BB76.6020702@FreeBSD.org> Date: Tue, 15 Jun 2010 22:01:44 +0200 Message-ID: From: Alexander Best To: Gabor Kovesdan Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: [CFT] BSDL iconv in base system X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2010 20:01:51 -0000 On Tue, Jun 15, 2010 at 7:56 PM, Alexander Best wrote: > On Tue, Jun 15, 2010 at 7:42 PM, Gabor Kovesdan wrote= : >> >>> /usr/src/lib/libc/iconv/citrus_none.c: In function >>> '_citrus_NONE_stdenc_cstomb': >>> /usr/src/lib/libc/iconv/citrus_none.c:114: warning: unused variable 're= t' >>> *** Error code 1 >>> >> >> I'm sorry, this one slipped in. Today I've checked the sources with clan= g >> and fixed some minor warnings, including this one. The new patch is here= : >> http://www.kovesdan.org/patches/iconv_base_integrate2.diff >> >> And a gzipped version: >> http://www.kovesdan.org/patches/iconv_base_integrate2.diff.gz > > thanks. i'll revert the previous patch and apply this new one. with the new patch: =3D=3D=3D> lib/libiconv_modules (all) =3D=3D=3D> lib/libiconv_modules/BIG5 (all) cc -fpic -DPIC -O2 -pipe -fno-strict-aliasing -funroll-loops -march=3Dnative --param max-inline-insns-single=3D32 -I/usr/src/lib/libiconv_modules/BIG5/../../libc/iconv -g -std=3Dgnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/lib/libiconv_modules/BIG5/citrus_big5.c -o citrus_big5.So cc1: warnings being treated as errors /usr/src/lib/libiconv_modules/BIG5/../../libc/iconv/citrus_stdenc_template.= h: In function '_citrus_BIG5_stdenc_cstomb': /usr/src/lib/libiconv_modules/BIG5/../../libc/iconv/citrus_stdenc_template.= h:138: warning: 'ret' may be used uninitialized in this function *** Error code 1 Stop in /usr/src/lib/libiconv_modules/BIG5. *** Error code 1 Stop in /usr/src/lib/libiconv_modules. *** Error code 1 Stop in /usr/src/lib. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. > > cheers. > alex > >> >> -- >> Gabor Kovesdan >> FreeBSD Volunteer >> >> EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org >> WEB: =A0 http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org >> >> > > > > -- > Alexander Best > --=20 Alexander Best