From owner-cvs-all Sun Oct 21 10: 7:45 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 7563737B401; Sun, 21 Oct 2001 10:07:25 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id f9LH7ET28680; Sun, 21 Oct 2001 18:07:16 +0100 (BST) (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id f9LH79b86891; Sun, 21 Oct 2001 18:07:09 +0100 (BST) (envelope-from brian@freebsd-services.com) Message-Id: <200110211707.f9LH79b86891@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Peter Wemm Cc: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/sys/conf Makefile.i386 In-Reply-To: Message from Peter Wemm of "Sun, 21 Oct 2001 00:17:54 PDT." <20011021071754.CF876380A@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 21 Oct 2001 18:07:09 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > Brian Somers wrote: > > brian 2001/10/17 06:57:32 PDT > > > > Modified files: > > sys/conf Makefile.i386 > > Log: > > Change kern.bootfile when mv'ing the kernel > > This backs out part of rev 1.169, which was an intentional change.. > > This is incomplete.. > what if it is the second 'make install'? > What if sysctl isn't in $PATH? > What if it is an old sysctl that needs the -w switch? There isn't > an error trap to eat the error code, will this cause 'make installkernel' > to fail? Hmm, it seems it does: > > peter@overcee[12:15am]/home/src/sys/i386/compile/OVERCEE-111# make install rm -rf /boot/kernel.old > mv /boot/kernel /boot/kernel.old > [ "`sysctl -n kern.bootfile`" != "/boot/kernel/kernel" ] || sysctl kern.bootfile=/boot/kernel.old/kernel > sysctl: must use -w to modify variables > *** Error code 1 > > Stop in /home/src/sys/i386/compile/OVERCEE. > > Nothing is supposed to be using this sysctl, it's purely informational > these days, and even then it has only part of the story. The booted kernel > may not even be reachable (eg: on an EFI filesystem or pulled in via tftp). I guess it's wrong information... Where is the name of the current kernel supposed to be gotten from ? None of the documentation seems to point anywhere else. Personally, I think my change was wrong. The installkernel code should check to see if kern.bootfile is already kernel.old, and if it is, shouldn't move /boot/kernel/ on top of it. WRT sysctl(8) not being in the path, are you suggesting that I spell it /sbin/sysctl ? And WRT the command failing, are you suggesting that I simply put a ``-'' in front of the command ? > Cheers, > -Peter > -- > Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au > "All of this is for nothing if we don't go to the stars" - JMS/B5 Cheers. -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message