From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Mar 12 05:30:01 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 119EC9AD for ; Wed, 12 Mar 2014 05:30:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E19133C6 for ; Wed, 12 Mar 2014 05:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2C5U0ig076031 for ; Wed, 12 Mar 2014 05:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2C5U0AP076020; Wed, 12 Mar 2014 05:30:00 GMT (envelope-from gnats) Resent-Date: Wed, 12 Mar 2014 05:30:00 GMT Resent-Message-Id: <201403120530.s2C5U0AP076020@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ECC96956 for ; Wed, 12 Mar 2014 05:27:50 +0000 (UTC) Received: from qmta07.emeryville.ca.mail.comcast.net (qmta07.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:43:76:96:30:64]) by mx1.freebsd.org (Postfix) with ESMTP id CD5953A1 for ; Wed, 12 Mar 2014 05:27:49 +0000 (UTC) Received: from omta09.emeryville.ca.mail.comcast.net ([76.96.30.20]) by qmta07.emeryville.ca.mail.comcast.net with comcast id cVTS1n0030S2fkCA7VToAk; Wed, 12 Mar 2014 05:27:48 +0000 Received: from jdc.koitsu.org ([76.102.14.35]) by omta09.emeryville.ca.mail.comcast.net with comcast id cVTm1n00j0lNtxY8VVTndA; Wed, 12 Mar 2014 05:27:48 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id BB0AD73A3B; Tue, 11 Mar 2014 22:27:46 -0700 (PDT) Message-Id: <20140312052746.BB0AD73A3B@icarus.home.lan> Date: Tue, 11 Mar 2014 22:27:46 -0700 (PDT) From: Jeremy Chadwick To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/187472: lang/ruby21 -- configure has mistakes/errors relating to pthread detection X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Jeremy Chadwick List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Mar 2014 05:30:01 -0000 >Number: 187472 >Category: ports >Synopsis: lang/ruby21 -- configure has mistakes/errors relating to pthread detection >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 12 05:30:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 9.2-STABLE amd64 >Organization: >Environment: System: FreeBSD icarus.home.lan 9.2-STABLE FreeBSD 9.2-STABLE #0 r262477: Tue Feb 25 01:04:30 PST 2014 root@icarus.home.lan:/usr/obj/usr/src/sys/X7SBA_RELENG_9_amd64 amd64 >Description: This may affect other ruby ports (ruby19, ruby20), I haven't checked. During configure-time, the following lines are shown (and easily missed because they scroll by so fast): checking for pthread_kill in -lpthread... yes ./configure: pthread,: not found checking for pthread_np.h... yes The problem appears to be around line 19613 of the configure script (not configure.in, I haven't reviewed that): 19608 if test x"$rb_with_pthread" = xyes; then 19609 $as_echo "#define _REENTRANT 1" >>confdefs.h 19610 19611 $as_echo "#define _THREAD_SAFE 1" >>confdefs.h 19612 19613 pthread, MAINLIBS="-pthread $MAINLIBS", 19614 $as_echo "#define HAVE_LIBPTHREAD 1" >>confdefs.h This looks quite broken. Since autoconf is used, the "source" for this comes from configure.in. The code for that: 2431 if test x"$rb_with_pthread" = xyes; then 2432 AC_DEFINE(_REENTRANT) 2433 AC_DEFINE(_THREAD_SAFE) 2434 [pthread], [MAINLIBS="-pthread $MAINLIBS"], 2435 AC_DEFINE(HAVE_LIBPTHREAD) Line 2434 shown above comes directly from files/patch-configure.in, so it appears to me someone needs to investigate the following: 1) If files/patch-configure.in is TRULY doing the correct thing for ruby21 (and possibly the other ports) -- or if it's even necessary (someone may want to talk to the Ruby folks), and, 2) Examination of post-patch in Makefile to make sure it's doing the right thing as well. I tried looking at the SVN annotations for this port, but the commit lfor the section where post-patch is is so old that it precedes use of Subversion thus the commit reason is unknown. >How-To-Repeat: See above. >Fix: Correct fix unknown at this time. >Release-Note: >Audit-Trail: >Unformatted: