From owner-freebsd-arch  Tue Oct  2 10:38:43 2001
Delivered-To: freebsd-arch@freebsd.org
Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40])
	by hub.freebsd.org (Postfix) with ESMTP
	id 578DC37B407; Tue,  2 Oct 2001 10:38:36 -0700 (PDT)
Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47])
	by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f92HcNk111260;
	Tue, 2 Oct 2001 13:38:23 -0400
Mime-Version: 1.0
X-Sender: drosih@mail.rpi.edu
Message-Id: <p05101003b7dfaa0a1270@[128.113.24.47]>
In-Reply-To: <XFMail.010928165401.jhb@FreeBSD.org>
References: <XFMail.010928165401.jhb@FreeBSD.org>
Date: Tue, 2 Oct 2001 13:38:20 -0400
To: John Baldwin <jhb@FreeBSD.ORG>, Peter Wemm <peter@wemm.org>
From: Garance A Drosihn <drosih@rpi.edu>
Subject: Re: Style Wars
Cc: arch@FreeBSD.ORG, Warner Losh <imp@harmony.village.org>,
	Julian Elischer <julian@elischer.org>
Content-Type: text/plain; charset="us-ascii" ; format="flowed"
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

At 4:54 PM -0700 9/28/01, John Baldwin wrote:
>I'm think 1b) is the one most people have favored so far and it is
>rather close to our existing style, so it's not that big of a change.
>Does anyone object to 1b)?  It basically results in the following
>changes: use 2 tab spaces instead of 1 for type names, put the entire
>type name before the tab(s), and if the type is too long, just use
>a space.
>
>>  1b)
>>
>>  struct foo {
>>          int             f_type;
>>          struct mtx      f_lock;
>>          const char      *f_name;
>>          volatile int    f_int;
>  >         u_int64_t       f_64;
>>          const volatile char f_cv;
>>          TAILQ_ENTRY(foo) f_link;
>  > };

This is the guideline that I prefer the most.  It probably should
include an example of a function-pointer.

	u_int64_t	f_64;
	void		(*fun_ptr)(int, char *[]);

(which, I assume, would show that you would be lining up the name of
the function pointer with the other variable names, so the argument
list continues on to the right).

-- 
Garance Alistair Drosehn            =   gad@eclipse.acs.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message