From owner-freebsd-questions Mon Sep 2 11:20: 6 2002 Delivered-To: freebsd-questions@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF64D37B400 for ; Mon, 2 Sep 2002 11:19:57 -0700 (PDT) Received: from tomts6-srv.bellnexxia.net (tomts6.bellnexxia.net [209.226.175.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD06543E72 for ; Mon, 2 Sep 2002 11:19:56 -0700 (PDT) (envelope-from matt@xena.gsicomp.on.ca) Received: from xena.gsicomp.on.ca ([65.95.177.86]) by tomts6-srv.bellnexxia.net (InterMail vM.5.01.04.19 201-253-122-122-119-20020516) with ESMTP id <20020902181906.NTZI20685.tomts6-srv.bellnexxia.net@xena.gsicomp.on.ca>; Mon, 2 Sep 2002 14:19:06 -0400 Received: from localhost (matt@localhost) by xena.gsicomp.on.ca (8.11.3/8.11.3) with ESMTP id g82H64x74255; Mon, 2 Sep 2002 13:06:05 -0400 (EDT) (envelope-from matt@xena.gsicomp.on.ca) Date: Mon, 2 Sep 2002 13:06:04 -0400 (EDT) From: Matthew Emmerton To: Matthew Seaman Cc: Marc Eckhert , freebsd-questions@FreeBSD.ORG Subject: Re: US Robotics V.Everything Internal ISA modem *WORKING!* In-Reply-To: <20020901090926.GA9263@happy-idiot-talk.infracaninophi> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-questions@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG The patch has already been submitted and returned, because "sharing fast interrupts is a bad thing to do". See PR/41227. Personally, I'd like the patch to go in so that we're not turning people away (remember, PCI sio devices work 100% fine on Linux and Windows) and in this case, works fine on FreeBSD as well. I think this is a perfect example of how good hardware (USR) works fine in tricky scenarios, but is where bad hardware would explode. Having code that "bends the rules" will act as a constant reminder to all the FreeBSD hackers out there that there are things to be redesigned, and since we're tearing everything apart in -CURRENT right now, there's no better time than the present. I'd do it myself, but I don't have enough understanding of why sharing fast interrupts is a problem to be able to formulate a proper solution. -- Matthew Emmerton || matt@gsicomp.on.ca GSI Computer Services || http://www.gsicomp.on.ca On Sun, 1 Sep 2002, Matthew Seaman wrote: > On Sat, Aug 31, 2002 at 12:53:02PM -0700, Marc Eckhert wrote: > > > > So now I have 2 questions. I would like to inquire as to how I can: > > > > 1) Have my line that I added to the sio.c file included in the FreeBSD > > source > > The best way to do this is to generate a diff showing the changes you > made to the sio.c file: > > diff -u sio.c.orig sio.c > sio.diff > > and attach it to a bug-report generated via send-pr: > > send-pr -P > /tmp/problem-report > vi /tmp/problem-report > send-pr -f /tmp/problem-report > > Since you're sending in a fix to a problem, you should put '[PATCH]' > as the first word of the synopsis. Don't forget to include supporting > information, like the pnpinfo output. > > The send-pr(1) man page and > http://www.freebsd.org/doc/en_US.ISO8859-1/articles/problem-reports/ > explain all about the use of send-pr(1) with FreeBSD. > > > 2) Have the book.txt file in /usr/share/doc/en/books/faq/ updated to > > specify that it is the line after Logical Device ID that should be tweaked, > > and not the line after Vendor ID. > > This is fodder for a second bug report. > > Cheers, > > Matthew > > > -- > Dr Matthew J Seaman MA, D.Phil. 26 The Paddocks > Savill Way > Marlow > Tel: +44 1628 476614 Bucks., SL7 1TH UK > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-questions" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-questions" in the body of the message