From owner-freebsd-i386@FreeBSD.ORG Tue Apr 24 01:40:13 2007 Return-Path: X-Original-To: freebsd-i386@freebsd.org Delivered-To: freebsd-i386@freebsd.org Received: from misaki (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with SMTP id 384C616A400; Tue, 24 Apr 2007 01:40:11 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Date: Tue, 24 Apr 2007 09:39:59 +0800 From: Ariff Abdullah To: John Baldwin , freebsd-amd64@freebsd.org Message-Id: <20070424093959.17d74e0b.ariff@FreeBSD.org> In-Reply-To: <200704231446.54021.jhb@freebsd.org> References: <20070420195444.20bc4d3a.ariff@FreeBSD.org> <200704231446.54021.jhb@freebsd.org> Organization: FreeBSD X-Mailer: /usr/local/lib/ruby/1.8/net/smtp.rb Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Tue__24_Apr_2007_09_39_59_+0800_CdDF/mKtTLHbbLTQ" Cc: freebsd-i386@freebsd.org Subject: Re: AMD64 K8 Family C1E dead apic timer fixup X-BeenThere: freebsd-i386@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: I386-specific issues for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2007 01:40:13 -0000 --Signature=_Tue__24_Apr_2007_09_39_59_+0800_CdDF/mKtTLHbbLTQ Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, 23 Apr 2007 14:46:53 -0400 John Baldwin wrote: > On Friday 20 April 2007 07:54:44 am Ariff Abdullah wrote: > > Will anybody object if I (or somebody else) commit this patch? > >=20 > > http://people.freebsd.org/~ariff/test/k8_c1e.diff > >=20 > > This should "fix" dead apic timer issues on latest AMD64 (Turion64 > > X2 mostly, or later revision) where C1 Enhanced (C1E) mode > > enabled. > >=20 > > Without this, the only way to make the timer work is to disable > > APIC or even worst, to avoid executing HLT instruction > > (machdep.cpu_idle_hlt=3D0), smp or non-smp. It affect both i386 and > > amd64. > >=20 > > See PR: i386/104678 for details. >=20 > Does this fix all of the Turion lapic timer hangs? Yes, and hopefully to the later revisions (if any) as well. > Some small tweaks to the comment would be: >=20 > - s/present/presence/ > - s/render/renders/ > - s/apic timer/local APIC timer/ > - s/dead, and/dead, so/ > - s/reading Interrupt/reading the Interrupt/ > - s/unset/clearing/ >=20 Thanks. > Also, is it ok to always mask off the upper 31 bits of the MSR > instead of preserving their current state? >=20 It should work either way, since the upper bits are read only. -- Ariff Abdullah FreeBSD ... Recording in stereo is obviously too advanced and confusing for us idiot ***** users :P ........ --Signature=_Tue__24_Apr_2007_09_39_59_+0800_CdDF/mKtTLHbbLTQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGLV/vlr+deMUwTNoRAmCrAJ4nA6aIj1lwXVHp8KlYVKkXQ4cPbQCfYxEq EERb4D+xbmRCrFdZKOsxPSs= =yH1S -----END PGP SIGNATURE----- --Signature=_Tue__24_Apr_2007_09_39_59_+0800_CdDF/mKtTLHbbLTQ--