From owner-cvs-all Sat Jul 24 14:54:48 1999 Delivered-To: cvs-all@freebsd.org Received: from smtp13.bellglobal.com (smtp13.bellglobal.com [204.101.251.52]) by hub.freebsd.org (Postfix) with ESMTP id 8DAA114D6A; Sat, 24 Jul 1999 14:54:43 -0700 (PDT) (envelope-from vanderh@ecf.toronto.edu) Received: from localhost.nowhere (ppp18412.on.bellglobal.com [206.172.130.92]) by smtp13.bellglobal.com (8.8.5/8.8.5) with ESMTP id RAA02817; Sat, 24 Jul 1999 17:54:02 -0400 (EDT) Received: (from tim@localhost) by localhost.nowhere (8.9.3/8.9.1) id RAA13816; Sat, 24 Jul 1999 17:52:35 -0400 (EDT) (envelope-from tim) Date: Sat, 24 Jul 1999 17:52:34 -0400 From: Tim Vanderhoek To: Nate Williams Cc: Matt Jacob , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/msgs msgs.1 msgs.c Message-ID: <19990724175234.C13618@mad> References: <199907241749.KAA61670@freefall.freebsd.org> <199907241753.LAA13980@mt.sri.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95i In-Reply-To: <199907241753.LAA13980@mt.sri.com>; from Nate Williams on Sat, Jul 24, 1999 at 11:53:10AM -0600 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sat, Jul 24, 1999 at 11:53:10AM -0600, Nate Williams wrote: > > usr.bin/msgs msgs.1 msgs.c > > Log: > > Apply suggested patch- seems reasonable. > > And what does that patch do? Asking the committer to go read the PR to > figure out what was done is much more work than adding the synopsis in > the commit message. In general, I think the average FreeBSD committer has a better style for writing commit messages than committers from other projects with closed CVS repos or that are just learning what a source repo is. Things a good commit message contains, 1) summary of the change 2) justification/reasoning 3) list of side effects 4) references (PRs, people, other commits, mail, etc). I usually completely ignore all of this when committing to some file of little import. I always feel a little guilty for this, though. Don't list bugreports as "PR: 5323, 325, 532" since the reports #325 and #532 won't have hyperlinks added to them by cvsweb. Try to making multiple changes in one commit when you should use several. Makes debugging easier, and makes it easier to pull patches from the repo. -- This is my .signature which gets appended to the end of my messages. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message