From owner-freebsd-current@FreeBSD.ORG  Thu Dec 15 03:27:38 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E7E4B1065672;
	Thu, 15 Dec 2011 03:27:37 +0000 (UTC)
	(envelope-from fjoe@samodelkin.net)
Received: from mail-tul01m020-f182.google.com (mail-tul01m020-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 957328FC0A;
	Thu, 15 Dec 2011 03:27:37 +0000 (UTC)
Received: by obbwd18 with SMTP id wd18so187542obb.13
	for <multiple recipients>; Wed, 14 Dec 2011 19:27:36 -0800 (PST)
MIME-Version: 1.0
Received: by 10.182.88.99 with SMTP id bf3mr574755obb.73.1323919656834; Wed,
	14 Dec 2011 19:27:36 -0800 (PST)
Received: by 10.182.76.225 with HTTP; Wed, 14 Dec 2011 19:27:36 -0800 (PST)
X-Originating-IP: [93.92.220.178]
In-Reply-To: <CAGH67wQGnSfnO0H4ok2=czm7uxdwY+BuDmtQdwuswjSBGt8szw@mail.gmail.com>
References: <201111291607.26546.jhb@freebsd.org>
	<A6C0CFB3-A657-41AA-8A2E-172D95BD0F98@bsdimp.com>
	<20111201002515.GA50028@freebsd.org>
	<CAGH67wQFecLHFsANmWFSr6e+99P1QY9erNzoXFmJG40RntFazQ@mail.gmail.com>
	<20111201014349.GA61475@freebsd.org>
	<CAGH67wT18DLu+OhOOw-Pjyq9az0pWD39y4nuDY-nDyPOKbmd8Q@mail.gmail.com>
	<CAGH67wQGnSfnO0H4ok2=czm7uxdwY+BuDmtQdwuswjSBGt8szw@mail.gmail.com>
Date: Thu, 15 Dec 2011 10:27:36 +0700
Message-ID: <CADe0-4niyiLyTSofbnpovb4B-WpjnC9VEEM3_GeZFi-xVws=LQ@mail.gmail.com>
From: Max Khon <fjoe@samodelkin.net>
To: Garrett Cooper <yanegomi@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: Alexander Best <arundel@freebsd.org>, Doug Barton <dougb@freebsd.org>,
	current@freebsd.org, Warner Losh <imp@bsdimp.com>
Subject: Re: Remove debug echo
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Dec 2011 03:27:38 -0000

Garrett,

On Thu, Dec 1, 2011 at 2:15 PM, Garrett Cooper <yanegomi@gmail.com> wrote:


> I've attached a patch that makes make do what I would like it to do;
> there are some other items that require cleanup to achieve the `argv0'
> prefixing that's available in gmake, but this is good enough for a
> meaningful traceback when things fail. Pastebin available here, just
> in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv
>
> $ cat ~/Makefile
> all:
>        cd $$HOME/foo; ${MAKE} $@
> $ cat ~/foo/Makefile
> all: foo bar barf yadda
>
> foo bar yadda:
>        @true
>
> baz:
>        @false
>
> barf: baz
> $ $PWD/make -j4 -f ~/Makefile all
> cd $HOME/foo; /usr/src/usr.bin/make/make all
> *** [baz] Error code 1
> 1 error
> *** [all] Error code 2
> 1 error
> $
>
> If someone would please, PLEASE commit this.. I will give you beer, or
> wine, or a copy of Skyrim, or a few months subscription to WoW, or
> something else of value to you that we could negotiate :)... I'm quite
> frankly tired of having to playing guessing games fishing through logs
> trying to determine build errors on FreeBSD if and when they do occur
> with pmake, and I'm sure that a number of developers and build/release
> engineers out there are in the same boat as I am.
>

Can you explain why did you remove MESSAGE() invocations in your patch?
Other than that the patch looks good to me.

Max