From owner-cvs-all Mon Feb 3 14:17:20 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96DEF37B401; Mon, 3 Feb 2003 14:17:18 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6CC143E4A; Mon, 3 Feb 2003 14:17:17 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.6/8.12.5) with SMTP id h13MH8P4089977; Mon, 3 Feb 2003 17:17:08 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Mon, 3 Feb 2003 17:17:07 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Juli Mallett Cc: Gordon Tetlow , Dag-Erling Smorgrav , phk@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_vol_ffs.c In-Reply-To: <20030203134932.A44770@FreeBSD.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 3 Feb 2003, Juli Mallett wrote: > * De: Gordon Tetlow [ Data: 2003-02-03 ] > [ Subjecte: Re: cvs commit: src/sys/geom geom_vol_ffs.c ] > > > - Although tunefs(8) won't let you set a volume label containing > > > anything but alphanumerics (IMHO, it should accept underscores as > > > well), there's nothing in g_vol_ffs_taste() that checks for invalid > > > characters in the label. What happens if I manually edit the > > > superblock and put a / in there? (imagine inserting a borrowed Zip > > > disk and boom...) > > > > I've got a commit in my tree that adds a comment about this. It's on > > my TODO list. I was thinking of adding . as a valid character as well > > (but disallowing leading periods for security reasons). > > Security reasons? What's wrong with things like ls hiding certain > volumes in /dev/vol/ if they aren't using -a or similar? Currently, there's a very small limit on the size of devfs device names. Poul-Henning has plans to increase that limit, meaning that a slightly deeper /dev is possible. It would also permit us to stick things like uuids in the devfs space. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message