From owner-cvs-src@FreeBSD.ORG Wed Apr 13 17:04:26 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D8BD16A4CE; Wed, 13 Apr 2005 17:04:26 +0000 (GMT) Received: from sasami.jurai.net (sasami.jurai.net [69.17.104.113]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8ABFD43D31; Wed, 13 Apr 2005 17:04:25 +0000 (GMT) (envelope-from mdodd@FreeBSD.ORG) Received: from sasami.jurai.net (winter@sasami.jurai.net [69.17.104.113]) by sasami.jurai.net (8.13.1/8.13.1) with ESMTP id j3DH4LOP008107; Wed, 13 Apr 2005 13:04:24 -0400 (EDT) (envelope-from mdodd@FreeBSD.ORG) Date: Wed, 13 Apr 2005 13:04:21 -0400 (EDT) From: "Matthew N. Dodd" X-X-Sender: winter@sasami.jurai.net To: Antoine Brodin In-Reply-To: <20050413184246.19212b84.antoine.brodin@laposte.net> Message-ID: <20050413124956.M3762@sasami.jurai.net> References: <200504130001.j3D01kuD081602@repoman.freebsd.org> <20050413184246.19212b84.antoine.brodin@laposte.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.5.6 (sasami.jurai.net [69.17.104.113]); Wed, 13 Apr 2005 13:04:24 -0400 (EDT) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/share/man/man4 unix.4 src/sys/sys socket.h un.h unpcb.h src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2005 17:04:26 -0000 On Wed, 13 Apr 2005, Antoine Brodin wrote: > I'm not sure it's safe to sooptcopyout/sooptcopyin while holding the > unp mutex in uipc_ctloutput. It can fault. I was concerned about this but saw that other code holds locks across sooptcopy*() calls. If there is a deadlock problem it may be time to add a per unpcb lock. -- 10 40 80 C0 00 FF FF FF FF C0 00 00 00 00 10 AA AA 03 00 00 00 08 00