From owner-cvs-ports@FreeBSD.ORG Thu Jun 2 21:04:11 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A077106566B; Thu, 2 Jun 2011 21:04:11 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward14.mail.yandex.net (forward14.mail.yandex.net [95.108.130.92]) by mx1.freebsd.org (Postfix) with ESMTP id 447078FC20; Thu, 2 Jun 2011 21:04:11 +0000 (UTC) Received: from smtp14.mail.yandex.net (smtp14.mail.yandex.net [95.108.131.192]) by forward14.mail.yandex.net (Yandex) with ESMTP id 92C211981194; Fri, 3 Jun 2011 01:04:09 +0400 (MSD) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1307048649; bh=4CNnObJkQcBlNjaobWuQDbwbvQhkW8eTidviOhmRXYQ=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=IZXwICOM/dWHS7RkVF0nhrf9bCz5Zl70q84Yq7pdB+lMc52itWycL3bxbCfd1V6qW dzS56sb+mPdcJ/0zaCVem+3nkK+dsJ4imzDNF+b7WbgUA6RuRBN4sD+cHCrzUWF2UN +/q8yQSZ4bDO/Eqjzh11/UJnwY2ahxEA/WuDvEak= Received: from smeshariki2.local (unknown [178.76.212.172]) by smtp14.mail.yandex.net (Yandex) with ESMTPSA id 1F3B819B8067; Fri, 3 Jun 2011 01:04:09 +0400 (MSD) Message-ID: <4DE7FA38.2040307@yandex.ru> Date: Fri, 03 Jun 2011 01:01:44 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; ru-RU; rv:1.9.2.17) Gecko/20110429 Thunderbird/3.1.10 MIME-Version: 1.0 To: Wesley Shields References: <201106021631.p52GVgHM038132@repoman.freebsd.org> <20110602165708.GA61311@atarininja.org> <4DE7D4B4.3040302@yandex.ru> <20110602195248.GA62894@atarininja.org> In-Reply-To: <20110602195248.GA62894@atarininja.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Yandex-Spam: 1 X-Mailman-Approved-At: Thu, 02 Jun 2011 23:08:14 +0000 Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/erlyvideo Makefile pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2011 21:04:11 -0000 02.06.2011 23:52, Wesley Shields пишет: > On Thu, Jun 02, 2011 at 10:21:40PM +0400, Ruslan Mahmatkhanov wrote: >> 02.06.2011 20:57, Wesley Shields ??????????: >> >>>> | @@ -39,6 +40,7 @@ post-patch: >>>> | ${WRKSRC}/priv/${PORTNAME}.conf.sample >>>> | @${FIND} ${WRKSRC} -type f -name .gitignore | ${XARGS} ${RM} >>>> | @${FIND} ${WRKSRC} -type f -name "*.bak" | ${XARGS} ${RM} >>>> | + @${FIND} ${WRKSRC} -type f -name "*.orig" | ${XARGS} ${RM} >>>> | @${RMDIR} ${WRKSRC}/src/plugins >>> >>> I understand Ruslan was just following the convention used in this port >>> but I don't like this construct. We should at least be doing -print0 | >>> xargs -0 if we are going to be using xargs like this. I, personally, >>> would prefer us to use the -delete option to find. >> >> I'm fully agree with that findelete stuff, so here is the patch, >> thanks for pointing out. Surely i picked this construct in some >> another port, but can't recall which one. > > Thanks for taking care of this quickly. I will try and scour the tree in > the upcoming days to find more cases of this. Here is complete (?) list of them - 112 ports: http://pastebin.com/7abRca2h I can prepare patches if wish > >>> >>> I wonder if there are other places in the ports tree where a similar >>> construct can be found that we should also cleanup. >>> >>> -- WXS >> >> There is plenty of ports that use `find | xargs rm/rmdir` construct. >> ros-*/rox-* ports for example. > > Thanks for pointing these out! > > -- WXS > > -- Regards, Ruslan