From owner-freebsd-stable  Sat Sep 14 19: 4: 3 2002
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 50EE537B400; Sat, 14 Sep 2002 19:04:02 -0700 (PDT)
Received: from nova.fnal.gov (nova.fnal.gov [131.225.121.207])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8819343E4A; Sat, 14 Sep 2002 19:04:01 -0700 (PDT)
	(envelope-from zingelman@fnal.gov)
Received: from localhost (tez@localhost)
	by nova.fnal.gov (8.11.6+Sun/8.11.6) with ESMTP id g8F240s01800;
	Sat, 14 Sep 2002 21:04:00 -0500 (CDT)
X-Authentication-Warning: nova.fnal.gov: tez owned process doing -bs
Date: Sat, 14 Sep 2002 21:04:00 -0500 (CDT)
From: Tim Zingelman <zingelman@fnal.gov>
X-X-Sender: tez@nova.fnal.gov
Reply-To: Tim Zingelman <zingelman@fnal.gov>
To: anholt@freebsd.org, <re@freebsd.org>
Cc: stable@freebsd.org
Subject: missing break in recent patch to agp_i810.c
Message-ID: <Pine.GSO.4.43.0209142034260.1655-100000@nova.fnal.gov>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG

My I810 system broke and gave this message...

 agp0: unknown memory configuration, disabling
 device_probe_and_attach: agp0 attach returned 22

with the 1.1.2.4 revision of agp_i810.c.  A little investigation shows
there is clearly a missing 'break;' in a switch statement.  The following
patch fixes it.

--- agp_i810.c.RELENG_4 Sat Sep 14 19:27:10 2002
+++ agp_i810.c  Sat Sep 14 20:56:16 2002
@@ -219,6 +219,7 @@
        case 0x71258086:
        case 0x11328086:
                sc->chiptype = CHIP_I810;
+               break;
        case 0x35778086:
        case 0x25628086:
                sc->chiptype = CHIP_I830;

Release engineering please consider commit approval for this fix.

Thanks.

 - Tim Zingelman


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message