From owner-cvs-all Fri Nov 13 21:34:14 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA17196 for cvs-all-outgoing; Fri, 13 Nov 1998 21:34:14 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA17190; Fri, 13 Nov 1998 21:34:10 -0800 (PST) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id QAA25530; Sat, 14 Nov 1998 16:33:47 +1100 Date: Sat, 14 Nov 1998 16:33:47 +1100 From: Bruce Evans Message-Id: <199811140533.QAA25530@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, msmith@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_shutdown.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > Modified files: > sys/kern kern_shutdown.c > Log: > Don't count non-local dirty buffers as outstanding when shutting down. > This avoids the fsck-on-reboot symptoms if you're shutting down with a > hung or unreachable NFS server mounted. Also remove non-local > filesystems from the mount list to prevent the system hanging when it tries > to unmount them (for the same reason). This needs more work: - it removes elements from the mount list more than once if there is more than one dirty buffer per non-local file system. This happens to work if the same element is removed several times without removal of another element, but it can corrupt the list if removals of different elements are interleaved. - it doesn't lock the mount list when changing it. Even for UP and non- giant-locked SMP, this may cause problems if the list is already locked. - it doesn't warn about the file systems that it removes from the mount list. - it stops the SHOW_BUSYBUFS code from showing the missing syncs. - it has style bugs. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message