From owner-freebsd-current@FreeBSD.ORG Thu Dec 15 03:39:22 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF8F2106564A; Thu, 15 Dec 2011 03:39:21 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 78AE78FC12; Thu, 15 Dec 2011 03:39:21 +0000 (UTC) Received: by ggnp1 with SMTP id p1so2161162ggn.13 for ; Wed, 14 Dec 2011 19:39:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=gr45Mul4LyvKew2cOH9Ug2a7MtdSwCQCuqA9YjA66Jc=; b=KCON0gAZpZ+ObLZbLJzoKiOC2mjzOTHiFKNxh1SjA5fdSsM0sruD3bDep82Jn1sS4D LfFh0BqNjfznZY/nTX3WBMllqUOLQ9ZXc7u3dxw4pKFtwBixQ4rkQYYCV8X8wMhjcEuI jusQLIK4pP4nNeX5peOitAxTZnKU13LpeGVQ0= MIME-Version: 1.0 Received: by 10.182.17.102 with SMTP id n6mr623307obd.56.1323920360748; Wed, 14 Dec 2011 19:39:20 -0800 (PST) Received: by 10.182.62.227 with HTTP; Wed, 14 Dec 2011 19:39:20 -0800 (PST) In-Reply-To: References: <201111291607.26546.jhb@freebsd.org> <20111201002515.GA50028@freebsd.org> <20111201014349.GA61475@freebsd.org> Date: Wed, 14 Dec 2011 19:39:20 -0800 Message-ID: From: Garrett Cooper To: Max Khon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Alexander Best , Doug Barton , current@freebsd.org, Warner Losh Subject: Re: Remove debug echo X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2011 03:39:22 -0000 On Wed, Dec 14, 2011 at 7:27 PM, Max Khon wrote: > Garrett, > > On Thu, Dec 1, 2011 at 2:15 PM, Garrett Cooper wrote= : > >> >> I've attached a patch that makes make do what I would like it to do; >> there are some other items that require cleanup to achieve the `argv0' >> prefixing that's available in gmake, but this is good enough for a >> meaningful traceback when things fail. Pastebin available here, just >> in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv >> >> $ cat ~/Makefile >> all: >> =A0 =A0 =A0 =A0cd $$HOME/foo; ${MAKE} $@ >> $ cat ~/foo/Makefile >> all: foo bar barf yadda >> >> foo bar yadda: >> =A0 =A0 =A0 =A0@true >> >> baz: >> =A0 =A0 =A0 =A0@false >> >> barf: baz >> $ $PWD/make -j4 -f ~/Makefile all >> cd $HOME/foo; /usr/src/usr.bin/make/make all >> *** [baz] Error code 1 >> 1 error >> *** [all] Error code 2 >> 1 error >> $ >> >> If someone would please, PLEASE commit this.. I will give you beer, or >> wine, or a copy of Skyrim, or a few months subscription to WoW, or >> something else of value to you that we could negotiate :)... I'm quite >> frankly tired of having to playing guessing games fishing through logs >> trying to determine build errors on FreeBSD if and when they do occur >> with pmake, and I'm sure that a number of developers and build/release >> engineers out there are in the same boat as I am. > > > Can you explain why did you remove MESSAGE() invocations in your patch? > Other than that the patch looks good to me. I thought that printing out MESSAGE and the more informative *printf was kind of redundant. Thanks! -Garrett PS A sidenote why I bypassed MESSAGE(..): if I used the macro, make would segfault as MESSAGE depends on targFmt and targPrefix being set to something sane (they both default to NULL -- one explicitly, the other implicitly because it's in the .BSS). These vars are only set in one section of code, but I took the easy route out to avoid accidentally breaking other code paths and because what I did in the previously attached patch was simple to implement and test.