From owner-freebsd-arch Wed Nov 7 13:20:41 2001 Delivered-To: freebsd-arch@freebsd.org Received: from InterJet.elischer.org (c421509-a.pinol1.sfba.home.com [24.7.86.9]) by hub.freebsd.org (Postfix) with ESMTP id F098A37B43B; Wed, 7 Nov 2001 13:20:09 -0800 (PST) Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id NAA72632; Wed, 7 Nov 2001 13:02:24 -0800 (PST) Date: Wed, 7 Nov 2001 13:02:23 -0800 (PST) From: Julian Elischer To: Robert Watson Cc: freebsd-arch@FreeBSD.org Subject: Re: Changing req->p to req->td in sysctl In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 7 Nov 2001, Robert Watson wrote: > > I'm in the process of pushing the (td) reference from ioctl() into > if_ioctl() so that the thread information is available in a number of new > places in the network stack. However, in order to pass it down, we now > need it in a few newer places further up the stack (bpfattach(), ...). this is one of the reasons I left it :-) > One of the places this touches is the sysctl() interface, where the > process is passed in via req->p. The attached patch replaces the proc > reference with a thread reference. Right now, it slightly increases > complexity elsewhere (adds an additional dereference), but when we move to > td->td_ucred, suser using the thread reference, and with the pushing of td > down the stack, this will actually be a net improvement for simplicity. > Please review, I'd like to commit in a day or two. > > Robert N M Watson FreeBSD Core Team, TrustedBSD Project > robert@fledge.watson.org NAI Labs, Safeport Network Services > > ? sys/i386/conf/LINT > Index: sys/compat/linux/linux_mib.c > =================================================================== > RCS file: /home/ncvs/src/sys/compat/linux/linux_mib.c,v Assuming LINT compiles, then This looks fine.... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message