From owner-freebsd-ports@FreeBSD.ORG  Thu Apr 14 01:19:20 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 04B2716A4CF
	for <ports@FreeBSD.org>; Thu, 14 Apr 2005 01:19:20 +0000 (GMT)
Received: from cubesquared.squbes.com (216-54-214-35.gen.twtelecom.net
	[216.54.214.35])	by mx1.FreeBSD.org (Postfix) with SMTP id 226D743D49
	for <ports@FreeBSD.org>; Thu, 14 Apr 2005 01:19:19 +0000 (GMT)
	(envelope-from bsdcrank@squbes.com)
Received: (qmail 63020 invoked from network); 14 Apr 2005 01:19:39 -0000
Received: from unknown (HELO a.mx.squbes.com)
	(bsdcrank@squbes.com@192.168.200.35)
	by cubesquared.squbes.com with SMTP; 14 Apr 2005 01:19:39 -0000
From: Gregg Cooper <bsdcrank@squbes.com>
To: marcus@FreeBSD.org
Date: Wed, 13 Apr 2005 21:19:17 -0400
Content-Type: text/plain; charset=iso-8859-1
X-Mailer: mail.squbes.com / 0.7.1
Message-Id: <20050414011919.226D743D49@mx1.FreeBSD.org>
cc: ports@FreeBSD.org
cc: harti@FreeBSD.org
Subject: FreeBSD Port: portlint-2.7.1
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Apr 2005 01:19:20 -0000

Joe,

You're _fast_!

After skimming your portlint updates, and harti's make parsing code (both
over my head), and the concerns raised over harti's good work, my
quick-n-dirty curiosity-enlightens grep:

find /usr/ports/ -name Makefile -exec grep -H \
'^\.[[:space:]]*\(else\|endif\)\([^[:space:]]\|[[:space:]]\+[^[:space:]#]\)'
\
{} ';'

yields the following (even after harti graciously fixed several ports):

/usr/ports/devel/linux-understand_ada/Makefile:.endif /* NOPORTDOCS */
/usr/ports/devel/linux-understand_c/Makefile:.endif /* NOPORTDOCS */
/usr/ports/devel/linux-understand_java/Makefile:.endif /* NOPORTDOCS */
/usr/ports/mail/dspam/Makefile:.        elseif defined(WITH_POSTGRESQL)
/usr/ports/mail/dspam-devel/Makefile:.  elseif defined(WITH_POSTGRESQL)
/usr/ports/multimedia/transcode/Makefile:.endif(WITH_AVIFILE)
/usr/ports/net/rp-pppoe/Makefile:.endif /* NOPORTDOCS */
/usr/ports/news/newsx/Makefile:.else !defined(WITHOUT_INN_2-X)

Ports transcode and newsx are probably getting undesired results, but they
put the slip on portlint. I'm sure you aren't interested in full
make/c/ruby/xyz parsing, and a line needs to be drawn somewhere ... but since
you were _so_ fast with the last update, I thought I'd share my learning
experience - along with the commendation!

Gregg