From owner-svn-src-all@FreeBSD.ORG Tue Jan 14 20:29:13 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 352B91C3 for ; Tue, 14 Jan 2014 20:29:12 +0000 (UTC) Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C662C15B8 for ; Tue, 14 Jan 2014 20:29:11 +0000 (UTC) Received: by mail-wg0-f41.google.com with SMTP id n12so4372522wgh.2 for ; Tue, 14 Jan 2014 12:29:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=mY8lvjZuUWppvLeus932K0w7eXIAYlXy8XV+cfAXKBE=; b=DtRoYhlQGgVMOFEMmL8YbPrLek2kwM8b3ptFWxt8p9VCwOpYSZya53P3skN2I05tBM xWOS0GW6yFhbU9G/kvPS6W02l+B33QA2j4SlqQqmsd1cyjawfhzwEaA1VM1WEtbS67YX YkW6aMYyeE9gnmijVgJWuv1/B+j9oPPr3Wobk9mRB0v0+uQ1AYOzPlO09v9pwTN6/Mqs jmEEeiMxx2dwZRzX7bifSeZpFAfiiJQEWwStaAd4hSx3rxGkksdjmkz5Vb+4qM0yqfUq 18bWEZwsbMFaFls+YkNy1A+/3P0gtAIwLUsrsywtWd99OSptS5fModC+37KF3zlEfY40 SRJg== X-Gm-Message-State: ALoCoQmqqTKc3KCQSa5bbCcTInks4+LNu/PF+twVvQXSeM/4Xtl0EsfO2a5X6ySsgICIzY/IQJYy X-Received: by 10.194.82.105 with SMTP id h9mr375628wjy.52.1389731344231; Tue, 14 Jan 2014 12:29:04 -0800 (PST) Received: from [192.168.1.118] (62.57.0.127.dyn.user.ono.com. [62.57.0.127]) by mx.google.com with ESMTPSA id ks3sm1492182wjc.10.2014.01.14.12.28.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 Jan 2014 12:28:59 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: svn commit: r260586 - head/bin/pax/tests From: Julio Merino In-Reply-To: <01D805C2-AB9D-48F5-A972-FC7E801DC21E@meroh.net> Date: Tue, 14 Jan 2014 21:28:55 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201401131217.s0DCHflD060494@svn.freebsd.org> <20140113135930.GR97375@ithaqua.etoilebsd.net> <01D805C2-AB9D-48F5-A972-FC7E801DC21E@meroh.net> To: Baptiste Daroussin X-Mailer: Apple Mail (2.1827) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Julio Merino , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 20:29:13 -0000 On Jan 13, 2014, at 15:34, Julio Merino wrote: > On Jan 13, 2014, at 14:59, Baptiste Daroussin = wrote: >=20 >> On Mon, Jan 13, 2014 at 12:17:41PM +0000, Julio Merino wrote: >>> +tap_test_program{name=3D"legacy_test", = required_programs=3D"/usr/bin/perl"} >>=20 >> Shouldn't that be /usr/local/bin/perl or ${LOCALBASE}/bin/perl, we = are trying >> hard on ports to remove by default /usr/bin/perl which is a legacy = from the >> removal of perl from base. >=20 > Only if legacy_test.sh is also modified to use /usr/local/bin/perl. = (I don't think using LOCALBASE is possible given that it's not = accessible from share/mk/.) >=20 > If it's the right thing to do, I can change it. FTR, I did this change as part of some other generalizations and = cleanups. Test programs that use the new TAP_TESTS_PERL feature of = tap.test.mk should get the right path to the perl interpreter.=