From owner-svn-src-all@freebsd.org Sun Apr 3 19:23:59 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59874B01C36 for ; Sun, 3 Apr 2016 19:23:59 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm26-vm0.bullet.mail.bf1.yahoo.com (nm26-vm0.bullet.mail.bf1.yahoo.com [98.139.213.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 134FF1949 for ; Sun, 3 Apr 2016 19:23:59 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1459711437; bh=53/zzjPG23ht642/3kmfol6Z3Jz6OCEWb3y+EBOuBhk=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=gekNb4x1drWFSUrpr45FA9l+gUpltVQ9g2zdpc+ZfylsFZ+Yvm8ygDwGM5DngCYn9ikBJCqBc5a3xAHbRChbxA0rDc1YaQKUd6Fy/HDytVfd1EjwMT3nsRlEeJTyhKyw79TyzTOsPdoW0UjSg3x9BlghBIew9ypjzY6aP8gcYiRayRhILA7BLLEoPM1kBVKhKGnEr7L+p6hgL4eVZiuDca1Sp6fr2matow5wTHZm2/Z7tE0MNCNmGAaw7QGChxk4ema3GHxSUM7L0O6M+fiknZP1G9qjFQFXzvHCzaLdRixUdXC4QQp4E4m0X+or/IJav2Arz4gF+9MZXbIepUDa1w== Received: from [98.139.170.181] by nm26.bullet.mail.bf1.yahoo.com with NNFMP; 03 Apr 2016 19:23:57 -0000 Received: from [68.142.230.64] by tm24.bullet.mail.bf1.yahoo.com with NNFMP; 03 Apr 2016 19:23:57 -0000 Received: from [127.0.0.1] by smtp221.mail.bf1.yahoo.com with NNFMP; 03 Apr 2016 19:23:57 -0000 X-Yahoo-Newman-Id: 264709.64855.bm@smtp221.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: yLDj23oVM1n15f7.kmdYGZuut.fxlOtdr0gRygFKEanApKJ k1Bm9b5AgN9pUCHMT6odhs6nB43TbnVQXcYIMxsAyHg5R5WESUYxlJb30jC3 GuLyiMQIMc9i97bmbWfblbKFQ0ViNIES65ZPmNYvkuN7eK4_JJT5wc7CZyuC hMhyqb7IcLQ5C8NOx.Fitz86KpMeEfMKqiFY5GANHVamHSU4gRBS3ITWvudw s4gHhul9WeBPp0F0bUE2AC2eFUxodCGeyKsn5jd388Vq9vvrGkrjPYTv55g. IWx0iR017wmR9Q2Z0wtLRBkTl69m.93Yv_sPbVFkfVPtNqb24q_OQzSCWBvV xg5uv6miaZiNSg3HUSFm.H2.MWuuyJamzRIHBP8XcTjEC0cFlLwJ4N8w5qZy SgZxuiKW7QsPdJ1oXmClDVAsd7jNOY_oPu2jLdsgXFenLs.paqYeNpM5jCB_ 7nNgQoCvUpj6k6EAiZddfrnyUN8mZJk9XEUSqAAzYDFRQV3sagAUam3LRbOa LucKD5A2GE_5maG8eIRRnQH2bXBgB2cvh6g-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r297525 - head/sys/compat/linux To: Bruce Evans References: <201604031440.u33EesB7057019@repo.freebsd.org> <20160404045828.M816@besplex.bde.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <57016E2A.4060301@FreeBSD.org> Date: Sun, 3 Apr 2016 14:25:30 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160404045828.M816@besplex.bde.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2016 19:23:59 -0000 On 03/04/2016 14:11, Bruce Evans wrote: > On Sun, 3 Apr 2016, Pedro F. Giffuni wrote: > >> Author: pfg >> Log: >> Fix indentation oops. >> >> Modified: >> head/sys/compat/linux/linux_misc.c >> >> Modified: head/sys/compat/linux/linux_misc.c >> ============================================================================== >> >> --- head/sys/compat/linux/linux_misc.c Sun Apr 3 14:38:26 2016 >> (r297524) >> +++ head/sys/compat/linux/linux_misc.c Sun Apr 3 14:40:54 2016 >> (r297525) >> @@ -896,12 +896,12 @@ linux_utimensat(struct thread *td, struc >> } >> timesp = times; >> >> - if (times[0].tv_nsec == UTIME_OMIT && >> - times[1].tv_nsec == UTIME_OMIT) >> /* This breaks POSIX, but is what the Linux kernel does >> * _on purpose_ (documented in the man page for utimensat(2)), >> * so we must follow that behaviour. */ >> - return (0); >> + if (times[0].tv_nsec == UTIME_OMIT && >> + times[1].tv_nsec == UTIME_OMIT) >> + return (0); >> } >> >> if (args->pathname != NULL) > > The comment is still not written in BSD style. > I didn't change the original. Is it worth it to do another commit to add lines for a beginning and end comment delimiters ? > The patch shows a bug in svn(?) diff. The comment was moved, but the > patch shows movement of the if statement. The indentation was only > changed in the return statement. > > The comment was also misindented. Moving it fixes this, but I prefer > it where it was. Precisely .. I moved the "if" so I would not have to indent further the comment. I find it more readable. > Comments are often placed before an if statement and > not properly worded for that placement. They say that something is > done unconditionally but that is clearly wrong since the action is > conditional on the if statement. Here "this" in the comment used to > refer to the action of returning, but is ambiguous enough to still make > sense after the move. It now refers to the action of doing the check > and sometimes returning. The block of code is short enough that the > ambiguity is easy to resolve. > > Bruce Pedro.