From owner-freebsd-gnome@FreeBSD.ORG  Thu Mar 10 13:25:55 2011
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: gnome@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BA002106566B;
	Thu, 10 Mar 2011 13:25:55 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 9BEA48FC17;
	Thu, 10 Mar 2011 13:25:54 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA25025;
	Thu, 10 Mar 2011 15:25:52 +0200 (EET) (envelope-from avg@freebsd.org)
Message-ID: <4D78D160.7010001@freebsd.org>
Date: Thu, 10 Mar 2011 15:25:52 +0200
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.15) Gecko/20110309 Lightning/1.0b2 Thunderbird/3.1.9
MIME-Version: 1.0
To: Alberto Villa <avilla@freebsd.org>
References: <4D692B50.4000807@freebsd.org> <4D7878BD.9020802@freebsd.org>
	<201103101232.05940.avilla@freebsd.org>
In-Reply-To: <201103101232.05940.avilla@freebsd.org>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: gnome@freebsd.org, kde@freebsd.org
Subject: Re: icon for optical disk
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2011 13:25:55 -0000

on 10/03/2011 13:32 Alberto Villa said the following:
> On Thursday 10 March 2011 08:07:41 Andriy Gapon wrote:
>> The function expects that for optical disks "info.category" would be
>> "volume" and "info.capabilities" would contain "volume.disc".
>> But our hal gives "volume.disc" value in the info.category property as I
>> can see with lshal.  And thus the match fails and an empty icon name is
>> returned from the function.
>> I've just double-checked with OpenSUSE installation that I have and 
> their
>> hal supplies the values that the solid code expects.
> 
> i'm not sure if that is supposed to be correct. this is from doc/spec/hal-
> spec-properties.xml:
> 
> <entry>
>   <literal>info.category</literal> (string)
> </entry>
> <entry>example: storage.cdrom</entry>
> <entry>No</entry>
> <entry>The prominent capability describing what the device is</entry>
> 
> googling for info.category examples, though, reveals only simple words 
> for it on linux (volume, storage...). a linuxism, maybe?
> 
> i'll try to get our hal behave as in linux, and we'll see

Well, an example is not a definitive specification.
And I thought that the hal was one big linuxism :-)

Anyway, thanks a lot for the patch, I will test it.

-- 
Andriy Gapon