From owner-cvs-all Wed Jan 20 06:59:47 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA08147 for cvs-all-outgoing; Wed, 20 Jan 1999 06:59:47 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA08137; Wed, 20 Jan 1999 06:59:37 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.9.2/8.9.2/Netplex) with ESMTP id WAA20451; Wed, 20 Jan 1999 22:59:26 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199901201459.WAA20451@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: Eivind Eklund cc: Robert Nordier , fenner@parc.xerox.com, bde@zeta.org.au, cvs-committers@FreeBSD.ORG Subject: Re: -Werror In-reply-to: Your message of "Wed, 20 Jan 1999 15:45:10 +0100." <19990120154510.A64384@bitbox.follo.net> Date: Wed, 20 Jan 1999 22:59:26 +0800 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Eivind Eklund wrote: > On Wed, Jan 20, 1999 at 04:31:29PM +0200, Robert Nordier wrote: > > but rewriting to eliminate the errors would violate a style(9) > > guideline (unnecessary parentheses). There's an awful lot of BSD > > code like this, that could cause huge {Net,Open}BSD diffs if > > rewritten. > > NetBSD and OpenBSD does, AFAIK, compile their kernel with -Wall > -Werror. I'm pretty sure I saw that NetBSD also do something like this for large chunks of userland too. If I recall correctly (I don't have the source handy), they have bsd.*.mk hook to enable tree based (Makefile.inc) setting of the flags, and allowing overrides on a per directory basis as well. Re: style(9).. Some argue that parentheses to aid readability are not "unnecessary". style(9) says "Don't add braces that aren't necessary." - it doesn't say ".. for correct compilation". Having code clear and readable is "necessary". :-) > Eivind. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message