From owner-freebsd-bugs@FreeBSD.ORG Thu May 5 13:50:05 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 88E9716A4CE for ; Thu, 5 May 2005 13:50:05 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 47D5543D68 for ; Thu, 5 May 2005 13:50:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j45Do5i1020822 for ; Thu, 5 May 2005 13:50:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j45Do5H0020821; Thu, 5 May 2005 13:50:05 GMT (envelope-from gnats) Resent-Date: Thu, 5 May 2005 13:50:05 GMT Resent-Message-Id: <200505051350.j45Do5H0020821@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Przemyslaw Frasunek Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2EEAF16A4CE for ; Thu, 5 May 2005 13:44:59 +0000 (GMT) Received: from mailhost.freebsd.lublin.pl (mailhost.freebsd.lublin.pl [193.138.118.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 260D043D31 for ; Thu, 5 May 2005 13:44:58 +0000 (GMT) (envelope-from venglin@freebsd.lublin.pl) Received: from lagoon.freebsd.lublin.pl (qmailr@lagoon.freebsd.lublin.pl [193.138.118.3])j45Diq8P026135 for ; Thu, 5 May 2005 15:44:52 +0200 (CEST) (envelope-from venglin@freebsd.lublin.pl) Received: (qmail 25911 invoked by uid 1001); 5 May 2005 13:44:52 -0000 Message-Id: <20050505134452.25852.qmail@lagoon.freebsd.lublin.pl> Date: 5 May 2005 13:44:52 -0000 From: Przemyslaw Frasunek To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/80661: [SECURITY] Missing NULL termination after strncpy() in rlogin(1) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Przemyslaw Frasunek List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2005 13:50:05 -0000 >Number: 80661 >Category: bin >Synopsis: [SECURITY] Missing NULL termination after strncpy() in rlogin(1) >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu May 05 13:50:04 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Przemyslaw Frasunek >Release: FreeBSD 4.11-STABLE i386 >Organization: czuby.net >Environment: System: FreeBSD lagoon.freebsd.lublin.pl 4.11-STABLE FreeBSD 4.11-STABLE #0: Tue Feb 8 12:36:09 CET 2005 root@riget.scene.pl:/usr/src/sys/compile/RIGET i386 >Description: usr.bin/rlogin/rlogin.c: #ifdef KERBEROS case 'k': dest_realm = dst_realm_buf; (void)strncpy(dest_realm, optarg, REALM_SZ); break; #endif Dest_realm buffer isn't NULL terminated if sizeof(optarg) == REALM_SZ leading to possible security vulnerability. Rlogin client is setuid root and offending code is executed before dropping privs. The bug is present only in RELENG_4 if rlogin is compiled with Kerberos support. RELENG_5 is dekerberized and therefore not buggy. >How-To-Repeat: N/A >Fix: --- usr.bin/rlogin/rlogin.c.old Thu May 5 15:41:13 2005 +++ usr.bin/rlogin/rlogin.c Thu May 5 15:42:46 2005 @@ -228,7 +228,7 @@ #ifdef KERBEROS case 'k': dest_realm = dst_realm_buf; - (void)strncpy(dest_realm, optarg, REALM_SZ); + (void)strlcpy(dest_realm, optarg, REALM_SZ); break; #endif case 'l': >Release-Note: >Audit-Trail: >Unformatted: