From owner-freebsd-ports@FreeBSD.ORG Sat May 23 09:26:33 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98814106564A; Sat, 23 May 2009 09:26:33 +0000 (UTC) (envelope-from maho.nakata@gmail.com) Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.169]) by mx1.freebsd.org (Postfix) with ESMTP id 5A7748FC23; Sat, 23 May 2009 09:26:33 +0000 (UTC) (envelope-from maho.nakata@gmail.com) Received: by wf-out-1314.google.com with SMTP id 24so686488wfg.7 for ; Sat, 23 May 2009 02:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:message-id:to:cc :subject:from:in-reply-to:references:x-mailer:mime-version :content-type:content-transfer-encoding; bh=5YFrhGHIbg0CrmSKV9UEuHuzgekFvXJEXlqwtvit5PY=; b=mlxaSiP1htHSRZViukiIxJE/c0dpKoFul2WZsiA1K2rr23eKmcYCQZVPNUcfvVkaBt Ahfjj5bKMul466pNqzmtiT+SxP8kjgMV5BdldO4sUnkDCgNn5z4S+DFrFL6oSidTLbVn W27mnS0dsspd3pBdILXvXd7YWjHf7vuxCwDxk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:message-id:to:cc:subject:from:in-reply-to:references :x-mailer:mime-version:content-type:content-transfer-encoding; b=QKYLMSFHqryexf+AVrwuqlOL+A7VDm4Dulp2b+5yHH7ZnnE0fA6LHmTcNwSzwRWNYo AS307jZckGXQ81OdNJUqFuq0KrtUubxQh9AyYOZqqMyunoTsXmoSuV7tu9GYKQ1/MvEj ipNRrVJ8/ey9WnYEKvKFqNJQmoLlACa12HBL4= Received: by 10.142.245.17 with SMTP id s17mr1678912wfh.62.1243070792939; Sat, 23 May 2009 02:26:32 -0700 (PDT) Received: from localhost (rikad42.riken.jp [134.160.214.42]) by mx.google.com with ESMTPS id 22sm3456833wfg.27.2009.05.23.02.26.29 (version=SSLv3 cipher=RC4-MD5); Sat, 23 May 2009 02:26:30 -0700 (PDT) Sender: Maho NAKATA Date: Sat, 23 May 2009 18:24:26 +0900 (JST) Message-Id: <20090523.182426.193741786.chat95@mac.com> To: naylor.b.david@gmail.com From: Maho NAKATA In-Reply-To: <200905231101.59467.naylor.b.david@gmail.com> References: <20090522.195350.193746535.chat95@mac.com> <20090522164138.236cb114@it.buh.tecnik93.com> <200905231101.59467.naylor.b.david@gmail.com> X-Mailer: Mew version 6.2 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sat_May_23_18_24_26_2009_908)--" Content-Transfer-Encoding: 7bit Cc: pgollucci@p6m7g8.com, itetcu@freebsd.org, freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2009 09:26:34 -0000 ----Security_Multipart(Sat_May_23_18_24_26_2009_908)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi David Many many thanks for your patch. I'll test it very soon. Just one comment > I believe openoffice-2* can me marked as SAFE while openoffice-3* should not > be marked at all (since it sometimes works..., very well for me :-). you can mark as SAFE for all of our ports. If it's broken, its OOo issue. We should identify if dependencies are missing. -devel ports can be unsafe but 3, 3-RC 2, 2-RC must be safe. Please wait a few days to say ok. Best, From: David Naylor Subject: Re: MAKE_JOBS_UNSAFE (some more ports) Date: Sat, 23 May 2009 11:01:56 +0200 > On Friday 22 May 2009 15:41:38 Ion-Mihai Tetcu wrote: >> On Fri, 22 May 2009 19:53:50 +0900 (JST) >> >> Maho NAKATA wrote: >> > In massive parallel build, OOo can be broken. We explicitly >> > fix them otherwise broken. I just test with MAXJOB = 4 or something >> > like that. >> > >> > > I had it complain about perl (or >> > > something) needing to be recompiled but that was because I >> > > interrupted the build process. It has always completed for me when >> > > using MAX* from the start. >> > >> > me too. but - note it just works for you. >> > >> > > I can make the patch, only thing is bsd.port.mk will need to be >> > > patched (simple enough though). >> >> I can run a few test builds on QAT and maybe Phillip can do the same on >> his tindy. Just drop us the patch ;-) >> Even if it only works with MAXJOB = 2, we mark it as such and the build >> will be faster. > > Please see attached for the patch. The changes to bsd.port.mk: > - MAKE_JOBS_NUMBER always defined > - MAKE_JOBS_NUMBER forced to 1 if UNSAFE of DISABLE > - MAKE_JOBS_NUMBER defaults (but user defined) to number of cores > > I've then used MAKE_JOBS_NUMBER to set MAXPROCESSES, MAXMODULES and > NUMOFPROCESSES for openoffice-* (not including 1.*). > > I believe openoffice-2* can me marked as SAFE while openoffice-3* should not > be marked at all (since it sometimes works..., very well for me :-). > > This patch just makes openoffice-* behave like other ports in regards to > parallel builds and the usual MAKE_JOBS variables now works as expected. > > Happy testing, > > David ----Security_Multipart(Sat_May_23_18_24_26_2009_908)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEABECAAYFAkoXwMwACgkQpcQqaPiEzflhlACdGiIxNUVA301Y1hUKZGtg3E3r kM8An3jXV6sYVcSZe3CBP6AbLjl1g/bU =87dh -----END PGP SIGNATURE----- ----Security_Multipart(Sat_May_23_18_24_26_2009_908)----