From owner-freebsd-ports@FreeBSD.ORG Fri Jun 20 01:39:56 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18A9E1065674 for ; Fri, 20 Jun 2008 01:39:56 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7CB0F8FC12 for ; Fri, 20 Jun 2008 01:39:55 +0000 (UTC) (envelope-from kris@FreeBSD.org) Message-ID: <485B0A6C.3080301@FreeBSD.org> Date: Fri, 20 Jun 2008 03:39:56 +0200 From: Kris Kennaway User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: freebsd-ports@freebsd.org References: <676047.76296.qm@web32706.mail.mud.yahoo.com> <20080619163501.GB12160@atarininja.org> <485A921C.80602@FreeBSD.org> <20080619210519.GV18873@graf.pompo.net> In-Reply-To: <20080619210519.GV18873@graf.pompo.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: regression-test X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2008 01:39:56 -0000 Thierry Thomas wrote: > Le Jeu 19 jui 08 à 19:06:36 +0200, Kris Kennaway > écrivait : > >> We *want* regression tests to be available unconditionally -- that is >> why I added the hook to the package build process to run them if >> present. Please don't hack around this because you think you're doing >> us a favour :-) > > I try to enable regression-test when possible, but the current > implementation is a post-build target, and some ports' testings need a > post-install target. In these cases, I enclose the regression-test > target between .ifdef MAINTAINER_MODE. I'd say those ports are broken; conceptually, you should be testing whether or not your port works *before* you install it, not after. Kris