From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 8 17:50:03 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8797E1065674 for ; Mon, 8 Sep 2008 17:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 620938FC1C for ; Mon, 8 Sep 2008 17:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m88Ho39x029062 for ; Mon, 8 Sep 2008 17:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m88Ho3dw029054; Mon, 8 Sep 2008 17:50:03 GMT (envelope-from gnats) Resent-Date: Mon, 8 Sep 2008 17:50:03 GMT Resent-Message-Id: <200809081750.m88Ho3dw029054@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ulrich Spörlein Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 63B3D1065670; Mon, 8 Sep 2008 17:46:24 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net [IPv6:2a01:198:200:2a::2]) by mx1.freebsd.org (Postfix) with ESMTP id D44698FC26; Mon, 8 Sep 2008 17:46:23 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from roadrunner.spoerlein.net (e180169130.adsl.alicedsl.de [85.180.169.130]) by acme.spoerlein.net (8.14.2/8.14.2) with ESMTP id m88HkD2Q020435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 8 Sep 2008 19:46:15 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.2/8.14.2) with ESMTP id m88HDa4i014768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 8 Sep 2008 19:13:36 +0200 (CEST) (envelope-from uqs@roadrunner.spoerlein.net) Received: (from uqs@localhost) by roadrunner.spoerlein.net (8.14.2/8.14.2/Submit) id m88HDaeK014767; Mon, 8 Sep 2008 19:13:36 +0200 (CEST) (envelope-from uqs) Message-Id: <200809081713.m88HDaeK014767@roadrunner.spoerlein.net> Date: Mon, 8 Sep 2008 19:13:36 +0200 (CEST) From: Ulrich Spörlein To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: secteam@FreeBSD.org Subject: ports/127214: [PATCH] security/portaudit: Please change to URL X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2008 17:50:03 -0000 >Number: 127214 >Category: ports >Synopsis: [PATCH] security/portaudit: Please change to URL >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Sep 08 17:50:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Ulrich Spörlein >Release: FreeBSD 7.1-PRERELEASE i386 >Organization: >Environment: >Description: Hello SecTeam, the current format, in which portaudit is printing its URLs is a pain in the ass to copy and paste anywhere. Usually a double click will select the space delimited word under the cursor, but thanks to the surrounding < > you cannot paste this into a browser easily. I also haven't seen used anywhere with URLs, just with email addresses. If there's no good reason to use please, please drop the surrounding brackets. >How-To-Repeat: >Fix: This will update the portaudit(1) tool and the printing via ports make(1) The webpage generating script would still need to be adjusted. --- portaudit.diff begins here --- Index: Mk/bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.604 diff -u -p -r1.604 bsd.port.mk --- Mk/bsd.port.mk 5 Sep 2008 19:41:43 -0000 1.604 +++ Mk/bsd.port.mk 8 Sep 2008 17:09:27 -0000 @@ -3355,7 +3355,7 @@ check-vulnerable: vlist=`${_EXTRACT_AUDITFILE} | ${GREP} "${PORTNAME}" | \ ${AWK} -F\| ' /^[^#]/ { \ if (!system("${PKG_VERSION} -T \"${PKGNAME}\" \"" $$1 "\"")) \ - print "=> " $$3 ".\n Reference: <" $$2 ">" \ + print "=> " $$3 ".\n Reference: " $$2 \ } \ '`; \ if [ -n "$$vlist" ]; then \ Index: ports-mgmt/portaudit/files/portaudit-cmd.sh =================================================================== RCS file: /home/ncvs/ports/ports-mgmt/portaudit/files/portaudit-cmd.sh,v retrieving revision 1.14 diff -u -p -r1.14 portaudit-cmd.sh --- ports-mgmt/portaudit/files/portaudit-cmd.sh 27 Dec 2007 09:54:23 -0000 1.14 +++ ports-mgmt/portaudit/files/portaudit-cmd.sh 8 Sep 2008 17:04:18 -0000 @@ -437,7 +437,7 @@ elif $opt_verbose; then print "Type of problem: " $3 "." split($2, ref, / /) for (r in ref) - print "Reference: <" ref[r] ">" + print "Reference: " ref[r] if (note) print "Note: " note print "" @@ -451,7 +451,7 @@ else print "Type of problem: " $3 "." split($2, ref, / /) for (r in ref) - print "Reference: <" ref[r] ">" + print "Reference: " ref[r] if (note) print "Note: " note print "" --- portaudit.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: