From owner-freebsd-current@FreeBSD.ORG  Fri May 19 09:05:17 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from localhost.my.domain (localhost [127.0.0.1])
	by hub.freebsd.org (Postfix) with ESMTP id AB2A716A41F;
	Fri, 19 May 2006 09:05:16 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
From: David Xu <davidxu@freebsd.org>
To: Rostislav Krasny <rosti.bsd@gmail.com>
Date: Fri, 19 May 2006 17:05:07 +0800
User-Agent: KMail/1.8.2
References: <20060430142408.fcd60069.rosti.bsd@gmail.com>
	<200605190802.08825.davidxu@freebsd.org>
	<20060519041052.ab8dbbe9.rosti.bsd@gmail.com>
In-Reply-To: <20060519041052.ab8dbbe9.rosti.bsd@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200605191705.07309.davidxu@freebsd.org>
Cc: is@rambler-co.ru, cperciva@freebsd.org, freebsd-current@freebsd.org
Subject: Re: FreeBSD-SA-06:14.fpu
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 May 2006 09:05:17 -0000

On Friday 19 May 2006 09:10, Rostislav Krasny wrote:

> Ok. What should I do before adding the above #ifdef's? Is it enough to
> change following files only?
>
> src/sys/conf/options
I think they are sys/conf/options.i386 and sys/conf/options.amd64

> src/sys/i386/conf/GENERIC
> src/sys/i386/conf/NOTES
> src/sys/i386/conf/PAE
> src/sys/i386/conf/SMP
> src/sys/amd64/conf/GENERIC
> src/sys/amd64/conf/NOTES
> src/sys/amd64/conf/SMP
>
I think modifying GENERIC and NOTES is enough.

> > but I would call it BUG_FXSAVE like Linux's select()
> > changed timeout value which only added incompatibility rather than
> > advantage.
>
> I don't know about Linux's select() but according to what I've seen on
> their "7466f9e72dac13452d871a3fb72fc7bd9c93c864" commit they use
> X86_FEATURE_FXSAVE_LEAK. What do you think about FXSAVE_LEAK instead of
> BUG_FXSAVE?

I have no objection.

David Xu