From owner-cvs-ports@FreeBSD.ORG  Wed Mar 10 18:29:47 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 7D2371065670; Wed, 10 Mar 2010 18:29:47 +0000 (UTC)
Date: Wed, 10 Mar 2010 18:29:47 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Martin Wilke <miwi@FreeBSD.org>
Message-ID: <20100310182947.GA75413@FreeBSD.org>
References: <201003101753.o2AHrRLT099735@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201003101753.o2AHrRLT099735@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net-mgmt/rackmonkey Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Mar 2010 18:29:47 -0000

On Wed, Mar 10, 2010 at 05:53:27PM +0000, Martin Wilke wrote:
> miwi        2010-03-10 17:53:27 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net-mgmt/rackmonkey  Makefile 
>   Log:
>   - Add missing dependency

It is good that you've reindented OPTIONS, but it would be nice to
reflect this in the commit log.  Also, PostgreSQL database support
standard knob is PGSQL, not POSTGRES (per our KNOBS file).  If you
decide to fix this, I would also mention that "Posgres" is obvious
typo (should be spelled "PostgreSQL", not "Posgres" or "Postgres"),
and "Use ?? Backend" sounds ambiguous (use as "use exclusively" or
"enable support for"?); "Backend" should also be spelled lowercase.

Would you like me to take care of these issues, perhaps?

./danfe