From owner-cvs-src@FreeBSD.ORG Fri Jun 6 19:11:24 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00D70106564A; Fri, 6 Jun 2008 19:11:24 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id B5E6A8FC16; Fri, 6 Jun 2008 19:11:23 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.64.3]) by phk.freebsd.dk (Postfix) with ESMTP id 208DE170E5; Fri, 6 Jun 2008 19:11:22 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.2/8.14.2) with ESMTP id m56JBL55001810; Fri, 6 Jun 2008 19:11:21 GMT (envelope-from phk@critter.freebsd.dk) To: Alan Cox From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 06 Jun 2008 18:38:43 GMT." <200806061838.m56Icu2E074642@repoman.freebsd.org> Date: Fri, 06 Jun 2008 19:11:21 +0000 Message-ID: <1809.1212779481@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_page.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2008 19:11:24 -0000 In message <200806061838.m56Icu2E074642@repoman.freebsd.org>, Alan Cox writes: >alc 2008-06-06 18:38:43 UTC > > FreeBSD src repository > > Modified files: > sys/vm vm_page.c > Log: > SVN rev 179623 on 2008-06-06 18:38:43Z by alc > > Essentially, neither madvise(..., MADV_DONTNEED) nor madvise(..., MADV_FREE) > work. (Moreover, I don't believe that they have ever worked as intended.) I remember they did have a measurable but minor impact on performance in systems which paged a lot, back when they were introduced, sort of 1995-ish. But with the subsequent plunge in RAM prices they never saw much use. Thanks for fixing them. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.