From owner-freebsd-hackers@FreeBSD.ORG  Mon Nov  9 15:50:21 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 58DBC106566C
	for <freebsd-hackers@freebsd.org>; Mon,  9 Nov 2009 15:50:21 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 29C638FC19
	for <freebsd-hackers@freebsd.org>; Mon,  9 Nov 2009 15:50:21 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id D342A46B29;
	Mon,  9 Nov 2009 10:50:20 -0500 (EST)
Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id 1D00B8A020;
	Mon,  9 Nov 2009 10:50:20 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-hackers@freebsd.org
Date: Mon, 9 Nov 2009 09:31:12 -0500
User-Agent: KMail/1.9.7
References: <permail-20091108021905f0889e8400001ff7-a_best01@message-id.uni-muenster.de>
In-Reply-To: <permail-20091108021905f0889e8400001ff7-a_best01@message-id.uni-muenster.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200911090931.12494.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Mon, 09 Nov 2009 10:50:20 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE
	autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: Alexander Best <alexbestms@math.uni-muenster.de>,
	Alan Cox <alc@cs.rice.edu>
Subject: Re: mmap(2) with MAP_ANON honouring offset although it shouldn't
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Nov 2009 15:50:21 -0000

On Saturday 07 November 2009 9:19:05 pm Alexander Best wrote:
> no problem. i've sent the final patch as followup to kern/71258 and also
> attached it to this message. to make it short. what's being changed by the
> patch:
> 
> 1) if MAP_ANON is defined and offset !=0  ====>  return EINVAL
> 2) if MAP_STACK is defined and offset !=0   ====>  offset = 0
> 
> would be great if you could have a look at the patch if you've got a spare
> minute.

I didn't think 2) changed?  I.e. both the old and new code do this, so only 1) 
is changing?

-- 
John Baldwin