From owner-freebsd-current@FreeBSD.ORG  Fri May 19 09:59:14 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 26E1C16A41F
	for <freebsd-current@freebsd.org>; Fri, 19 May 2006 09:59:14 +0000 (UTC)
	(envelope-from rosti.bsd@gmail.com)
Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 06B3E43D53
	for <freebsd-current@freebsd.org>; Fri, 19 May 2006 09:59:12 +0000 (GMT)
	(envelope-from rosti.bsd@gmail.com)
Received: by ug-out-1314.google.com with SMTP id m3so703678uge
	for <freebsd-current@freebsd.org>; Fri, 19 May 2006 02:59:11 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type:content-transfer-encoding;
	b=Bjk2433900XIzOZ8il2NIp/YqaVS81E7yNcJ1pXcF57CGbQIl5hQjf7ENk+YfgQoHYK8zsKfaGvqouGve3ZrxzQr27WNrtMd67dtjZ7su56YdifVsFv9hzz3QxFmlCuBgk9GmzIEgevgzUA+NcMupUMFvDZjQlbozVHWV8y0REg=
Received: by 10.78.47.9 with SMTP id u9mr536655huu;
	Fri, 19 May 2006 02:34:09 -0700 (PDT)
Received: from saturn.lan ( [212.143.154.227])
	by mx.gmail.com with ESMTP id 35sm506200huc.2006.05.19.02.34.04;
	Fri, 19 May 2006 02:34:08 -0700 (PDT)
Date: Fri, 19 May 2006 12:34:06 +0300
From: Rostislav Krasny <rosti.bsd@gmail.com>
To: David Xu <davidxu@freebsd.org>
Message-Id: <20060519123406.3cdf83e1.rosti.bsd@gmail.com>
In-Reply-To: <200605191705.07309.davidxu@freebsd.org>
References: <20060430142408.fcd60069.rosti.bsd@gmail.com>
	<200605190802.08825.davidxu@freebsd.org>
	<20060519041052.ab8dbbe9.rosti.bsd@gmail.com>
	<200605191705.07309.davidxu@freebsd.org>
X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.17; i386-portbld-freebsd6.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: is@rambler-co.ru, cperciva@freebsd.org, freebsd-current@freebsd.org
Subject: Re: FreeBSD-SA-06:14.fpu
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 May 2006 09:59:14 -0000

On Fri, 19 May 2006 17:05:07 +0800
David Xu <davidxu@freebsd.org> wrote:

> On Friday 19 May 2006 09:10, Rostislav Krasny wrote:
> 
> > Ok. What should I do before adding the above #ifdef's? Is it enough to
> > change following files only?
> >
> > src/sys/conf/options
> I think they are sys/conf/options.i386 and sys/conf/options.amd64

Ok, then should I also change sys/conf/options.pc98 ?
I don't know much about the PC98. What processors there are in use?

> > src/sys/i386/conf/GENERIC
> > src/sys/i386/conf/NOTES
> > src/sys/i386/conf/PAE
> > src/sys/i386/conf/SMP
> > src/sys/amd64/conf/GENERIC
> > src/sys/amd64/conf/NOTES
> > src/sys/amd64/conf/SMP
> >
> I think modifying GENERIC and NOTES is enough.

Then PAE and SMP kernels will be vulnerable on AMD by default?

> > > but I would call it BUG_FXSAVE like Linux's select()
> > > changed timeout value which only added incompatibility rather than
> > > advantage.
> >
> > I don't know about Linux's select() but according to what I've seen on
> > their "7466f9e72dac13452d871a3fb72fc7bd9c93c864" commit they use
> > X86_FEATURE_FXSAVE_LEAK. What do you think about FXSAVE_LEAK instead of
> > BUG_FXSAVE?
> 
> I have no objection.

Ok, I'll use FXSAVE_LEAK.