From owner-cvs-all@FreeBSD.ORG Tue Dec 28 06:24:56 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CD8116A52C; Tue, 28 Dec 2004 06:24:56 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2432943D48; Tue, 28 Dec 2004 06:24:56 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id iBS6OtFS057128; Mon, 27 Dec 2004 22:24:55 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id iBS6OsRv057126; Mon, 27 Dec 2004 22:24:54 -0800 (PST) (envelope-from obrien) Date: Mon, 27 Dec 2004 22:24:54 -0800 From: "David O'Brien" To: "Andrew R. Reiter" Message-ID: <20041228062454.GA56882@dragon.nuxi.com> References: <200412262252.iBQMqPe7060613@repoman.freebsd.org> <20041227005456.GA57720@xor.obsecurity.org> <200412271600.26989.jhb@FreeBSD.org> <20041227172424.A85914@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041227172424.A85914@fledge.watson.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: rwatson@freebsd.org cc: cvs-all@freebsd.org cc: John Baldwin Subject: Re: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Dec 2004 06:24:57 -0000 On Mon, Dec 27, 2004 at 05:27:44PM -0500, Andrew R. Reiter wrote: > On Mon, 27 Dec 2004, John Baldwin wrote: > > :On Sunday 26 December 2004 07:54 pm, Kris Kennaway wrote: > :> On Sun, Dec 26, 2004 at 10:52:24PM +0000, Robert Watson wrote: > :> > rwatson 2004-12-26 22:52:24 UTC > :> > > :> > FreeBSD src repository > :> > > :> > Modified files: > :> > sys/kern subr_witness.c > :> > Log: > :> > Add "show alllocks" command to DDB, which dumps a list of processes > :> > and threads currently holding sleep mutexes (and spin mutexes for > :> > curthread). This can be quite useful in looking for a lock condition > :> > summary for a system, as it avoids manually iterating through threads > :> > and processes to find all the interesting locks. > :> > > :> > NB: "alllocks" is up there with "lockedvnods" for a bad argument for > :> > show. > :> > :> ITYM "allloks" or perhaps "alllockes" (conservation of vowels). > : > :If you want a better name you could do 'show locks /a' instead. That is, add > :support to 'show locks' for the /a option (see 'show ktr' for how you would > :handle this by looking at 'modif'). > : > > Seems like a good idea to me, John. My only -- very minor -- issue with > that is using '/' as the flag delimiter. Not trying to be an asshole or > anything, just seems to me that (unless there is some ddb options already > there that use '/') using the forward slash is very cmd.exe-esque. VAX VMS actually. -- -- David (obrien@FreeBSD.org)