From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Apr  1 12:30:04 2009
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 67516106567B
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed,  1 Apr 2009 12:30:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 35F2D8FC1E
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed,  1 Apr 2009 12:30:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n31CU3Xm033050
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Wed, 1 Apr 2009 12:30:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n31CU3uN033046;
	Wed, 1 Apr 2009 12:30:03 GMT (envelope-from gnats)
Date: Wed, 1 Apr 2009 12:30:03 GMT
Message-Id: <200904011230.n31CU3uN033046@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Nikos Ntarmos <ntarmos@cs.uoi.gr>
Cc: 
Subject: Re: ports/133231: [PATCH] x11-wm/awesome: add D-Bus option
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Nikos Ntarmos <ntarmos@cs.uoi.gr>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Apr 2009 12:30:05 -0000

The following reply was made to PR ports/133231; it has been noted by GNATS.

From: Nikos Ntarmos <ntarmos@cs.uoi.gr>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: ports/133231: [PATCH] x11-wm/awesome: add D-Bus option
Date: Wed, 1 Apr 2009 15:23:58 +0300

 --AqsLC8rIMeq19msA
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 The patch looks good to me but the portrevision will require a bump.
 Please used the attached diff instead (the same as the one submitted by
 Pierre plus a hunk for the portrevision).
 
 Thanks.
 
 \n\n
 
 --AqsLC8rIMeq19msA
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="awesome-dbus-option-portrevision.diff"
 
 --- Makefile.orig
 +++ Makefile
 @@ -7,6 +7,7 @@
  
  PORTNAME=	awesome
  PORTVERSION=	3.2
 +PORTREVISION=	1
  CATEGORIES=	x11-wm
  MASTER_SITES=	http://awesome.naquadah.org/download/ \
  		http://redundancy.redundancy.org/mirror/
 @@ -22,7 +23,6 @@
  		xcb-util>=0.3.3:${PORTSDIR}/x11/xcb-util \
  		xproto>=7.0.11:${PORTSDIR}/x11/xproto
  LIB_DEPENDS=	cairo.2:${PORTSDIR}/graphics/cairo \
 -		dbus-1.3:${PORTSDIR}/devel/dbus \
  		ev.3:${PORTSDIR}/devel/libev \
  		freetype.9:${PORTSDIR}/print/freetype2 \
  		xcb.2:${PORTSDIR}/x11/libxcb \
 @@ -43,6 +43,8 @@
  MANCOMPRESSED=	yes
  PORTDOCS=	AUTHORS BUGS LICENSE README
  
 +OPTIONS+=	DBUS "Enable D-BUS support" On
 +
  .include <bsd.port.pre.mk>
  
  .if	(exists(${LOCALBASE}/libdata/pkgconfig/cairo.pc) && \
 @@ -50,12 +52,19 @@
  IGNORE=	cannot find dependency: The cairo exists but not with XCB support. Please reinstall graphics/cairo with XCB support
  .endif
  
 +.ifdef(WITH_DBUS)
 +LIB_DEPENDS += dbus-1.3:${PORTSDIR}/devel/dbus
 +CMAKE_ARGS += -DWITH_DBUS=YES
 +.else
 +CMAKE_ARGS += -DWITH_DBUS=NO
 +.endif
 +
  pre-configure:
  	@${REINPLACE_CMD} \
  	-e 's/"generate luadoc" ON/\"generate luadoc" OFF/g' \
  		${WRKSRC}/awesomeConfig.cmake
  	@${REINPLACE_CMD} \
 -	-e 's,tr ,env LC_ALL="C" tr ,g' \
 +	-e 's,tr ,env LC_ALL="C" ${TR} ,g' \
  	-e 's,gperf,${LOCALBASE}/bin/gperf,g' \
  		${WRKSRC}/build-utils/gperf.sh
  .if defined(NOPORTDOCS)
 
 --AqsLC8rIMeq19msA--