From owner-cvs-all@FreeBSD.ORG Mon Aug 1 14:04:23 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A866716A420; Mon, 1 Aug 2005 14:04:23 +0000 (GMT) (envelope-from mistry.7@osu.edu) Received: from crumpet.united-ware.com (ddsl-66-42-172-210.fuse.net [66.42.172.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EFFE43D45; Mon, 1 Aug 2005 14:04:22 +0000 (GMT) (envelope-from mistry.7@osu.edu) Received: from [192.168.1.101] (ddsl-66-42-172-210.fuse.net [66.42.172.210]) (authenticated bits=0) by crumpet.united-ware.com (8.12.8p2/8.12.8) with ESMTP id j71E3rXk022684 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Mon, 1 Aug 2005 10:03:53 -0400 (EDT) (envelope-from mistry.7@osu.edu) From: Anish Mistry To: Alexander Leidinger Date: Mon, 1 Aug 2005 10:03:48 -0400 User-Agent: KMail/1.8 References: <200507311046.j6VAktvC055088@repoman.freebsd.org> In-Reply-To: <200507311046.j6VAktvC055088@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2148256.Il1SaXOFRD"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200508011004.01667.mistry.7@osu.edu> X-Spam-Status: No, hits=-0.9 required=5.0 tests=BAYES_99,J_CHICKENPOX_65, MYFREEBSD2 autolearn=no version=2.64 X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on crumpet.united-ware.com X-Virus-Scanned: ClamAV 0.86/1000/Sun Jul 31 15:28:06 2005 on crumpet.united-ware.com X-Virus-Status: Clean Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_hints.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2005 14:04:23 -0000 --nextPart2148256.Il1SaXOFRD Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 31 July 2005 06:46 am, Alexander Leidinger wrote: > netchild 2005-07-31 10:46:55 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_hints.c > Log: > The resource_xxx routines in subr_hints.c are called before and > after the kenv environment in kern_environment.c switches to > dynamic kenv. The prior call sets the static variable hintp to the > static hints in subr_hints.c (hintmode=3D=3D0). > > However, changes to the environment are not detected by the > resource_xxx lookups after the change to dynamic kernel > environment, so the lookup routines only report the old stuff of > hintmode=3D=3D0, even after the change to the dynamic kenv. This causes > kenv users to see a different environment than the kernel routines. > > This is a problem in the mixer.c code that looks up initial mixer > volume settings from the hints: If the hints are dynamic and not > from the device.hints file, mixer.c doesn't see them, but kenv > does. > > The patch from the PR (modified to comply to the style of the > function) solves this. > > PR: 83686 > Submitted by: Harry Coin > > Revision Changes Path > 1.12 +2 -0 src/sys/kern/subr_hints.c These 2 PR can also be closed: http://www.freebsd.org/cgi/query-pr.cgi?pr=3D84033 http://www.freebsd.org/cgi/query-pr.cgi?pr=3D84034 =2D-=20 Anish Mistry --nextPart2148256.Il1SaXOFRD Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBC7ivRxqA5ziudZT0RAjLEAJ90eUnlExSH29kscYjL1wjCGOLXOgCfa1kF 2I/2BFcnlEG5LUJw2HmFSVw= =WUid -----END PGP SIGNATURE----- --nextPart2148256.Il1SaXOFRD--