From owner-freebsd-ports@FreeBSD.ORG  Wed Oct 23 13:10:48 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 3CB9778A;
 Wed, 23 Oct 2013 13:10:48 +0000 (UTC)
 (envelope-from makc@freebsd.org)
Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id B57E82D46;
 Wed, 23 Oct 2013 13:10:47 +0000 (UTC)
Received: from mercury.ph.man.ac.uk [130.88.75.175:27214] (HELO/EHLO
 mercury.ph.man.ac.uk, authenticated with LOGIN)
 by mail.issp.ac.ru with ESMTP/inet id r9NDAMQ5010632 (using TLSv1/SSLv3,
 with cipher DHE-RSA-AES256-SHA (256 bits), verified NO)
 Wed, 23 Oct 2013 17:10:24 +0400 (MSK)
From: Max Brazhnikov <makc@freebsd.org>
To: freebsd-ports@freebsd.org
Subject: Re: [math/scilab] configuration failure by error in version check of
 hdf5
Date: Wed, 23 Oct 2013 13:10:28 +0000
Message-ID: <4269055.QsbE8oRuxU@mercury.ph.man.ac.uk>
User-Agent: KMail/4.11 (FreeBSD/9.2-STABLE; KDE/4.11.0; amd64; ; )
In-Reply-To: <201310222319.r9MNJtYs078148@gw.catspoiler.org>
References: <201310222319.r9MNJtYs078148@gw.catspoiler.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: ports@freebsd.org, Don Lewis <truckman@freebsd.org>, 1wkmmr@gmail.com,
 iwaki@eng.niigata-u.ac.jp
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Oct 2013 13:10:48 -0000

On Tue, 22 Oct 2013 16:19:55 -0700 Don Lewis wrote:
> On  9 Oct, Mamoru Iwaki wrote:
> > Hi,
> > 
> > Re: math/scilab (Revision 327746)
> > 
> > I have failed to configure this port in compilation stage these days.
> > It is caused by an error in version check code for hdf5.  Because the
> > code writen in Java uses String.compareTo() for numeric comparision,
> > "1.8.10" is not recognized as a newer one than "1.8.4".
> > Could somebody correct this easy bug?
> 
> Scilab 5.4.1 is out now, so the port should probably be updated.  This
> version of scilab removed the version check for hdf5.
> 
> This is the patch that I'm using with the current port.  Just drop it in
> the files directory, run "make clean", and then rebuild.
> 
> --- configure.orig	2013-10-09 00:04:19.000000000 -0700
> +++ configure	2013-10-09 10:41:39.000000000 -0700
> @@ -12226,14 +12226,15 @@
>  
>  public class conftest {
>      public static void main(String[] argv) {
> -        String minVersion="1.8.4";
> +        int minVersion=10804;
>                              int[] vers = new int[3];
>                  try { H5.H5get_libversion(vers); }
>                  catch (Throwable ex) {System.exit(-1);}
>                  String ver = vers[0] + "."+ vers[1] +"."+vers[2];
> +                int Version = 10000*vers[0] + 100*vers[1] + vers[2];
>  
>                              System.out.println(ver);
> -                                  if (minVersion.compareTo(ver) > 0) {
> +                                  if (minVersion > Version) {
>                                     System.exit(-1);
>                                  }

I've committed this patch, thanks!

Max