From owner-freebsd-current  Thu Aug 19 11:38:31 1999
Delivered-To: freebsd-current@freebsd.org
Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP
	id A75711527F; Thu, 19 Aug 1999 11:38:24 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.2/8.9.2) id LAA95045;
	Thu, 19 Aug 1999 11:37:15 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <199908191837.LAA95045@bubba.whistle.com>
Subject: Re: NFS HEADS UP (was Re: cvs commit: src/sys/nfs nfsm_subs.h xdr_subs.h)
In-Reply-To: <199908191829.LAA57025@apollo.backplane.com> from Matthew Dillon at "Aug 19, 1999 11:29:31 am"
To: dillon@apollo.backplane.com (Matthew Dillon)
Date: Thu, 19 Aug 1999 11:37:15 -0700 (PDT)
Cc: bright@rush.net (Alfred Perlstein),
	eivind@FreeBSD.ORG (Eivind Eklund), peter@FreeBSD.ORG (Peter Wemm),
	current@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Matthew Dillon writes:
> :On a somewhat similar note, what do you think about converting a lot
> :of the NFS macros to functions, yes i know it will be difficult, but
> :there is so much forced inlining it just seems like it would reduce
> :the codesize signifigantly and play nicer with the CPU cache.
> :
> :It would also make the code a lot more readable.
> :
> :Worthwhile exercise?
> :
> :-Alfred Perlstein - [bright@rush.net|bright@wintelcom.net] 
> 
>     Well, the issue with converting many of the macros to inline functions
>     is with the embedded goto's and references to variables defined outside 
>     the macros.  Converting them to functions would basically require 
>     rewriting a huge chunk of NFS code.  
> 
>     This is one of those "If it ain't broke, don't fix it" scenarios, I'm
>     afraid.  It would take too long to redo it all (and remember, I'm the
>     guy who usually *likes* rewriting code!).  As much as I would like to
>     make NFS more readable, it just isn't worth the effort.

It still might be a "worthwhile exercise", if your goal is simply
to increase your understanding of the NFS code.

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message