From owner-svn-src-all@FreeBSD.ORG Wed Aug 19 09:56:00 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 029B3106564A; Wed, 19 Aug 2009 09:56:00 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail01.syd.optusnet.com.au (mail01.syd.optusnet.com.au [211.29.132.182]) by mx1.freebsd.org (Postfix) with ESMTP id 735A48FC15; Wed, 19 Aug 2009 09:55:59 +0000 (UTC) Received: from c122-106-152-1.carlnfd1.nsw.optusnet.com.au (c122-106-152-1.carlnfd1.nsw.optusnet.com.au [122.106.152.1]) by mail01.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n7J9tpSv006433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Aug 2009 19:55:52 +1000 Date: Wed, 19 Aug 2009 19:55:50 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Pawel Jakub Dawidek In-Reply-To: <20090818183858.GB1794@garage.freebsd.pl> Message-ID: <20090819194425.S35105@delplex.bde.org> References: <200908181355.n7IDtmqT019165@svn.freebsd.org> <4A8AC814.2070804@errno.com> <3bbf2fe10908181106u159934b9ofc4c2a5e4793b692@mail.gmail.com> <20090818183858.GB1794@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Attilio Rao , Sam Leffler , svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r196358 - in head: share/man/man9 sys/kern sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2009 09:56:00 -0000 On Tue, 18 Aug 2009, Pawel Jakub Dawidek wrote: > On Tue, Aug 18, 2009 at 08:06:17PM +0200, Attilio Rao wrote: >> 2009/8/18 Sam Leffler : >>> Pawel Jakub Dawidek wrote: >>>> Log: >>>> Remove unused taskqueue_find() function. >>>> Reviewed by: dfr >>>> Approved by: re (kib) >>> >>> I don't understand why this should be removed (let alone during a code >>> freeze). I can think of several uses for this function including a ddb cmd >>> that takes a taskq name and dumps it's contents. The overhead of >>> maintaining the global list appears minimal. >> >> FWIW, I agree with Sam. > > The only use I could think of was exactly what Sam suggested - a DDB > command and that was the only possible use I found. And ddb cannot call it, since it uses locks unconditionally. Bruce