From owner-freebsd-bugs  Sun Jul 15 10:30: 5 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 535B437B403
	for <freebsd-bugs@hub.freebsd.org>; Sun, 15 Jul 2001 10:30:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f6FHU1f96888;
	Sun, 15 Jul 2001 10:30:01 -0700 (PDT)
	(envelope-from gnats)
Date: Sun, 15 Jul 2001 10:30:01 -0700 (PDT)
Message-Id: <200107151730.f6FHU1f96888@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Chris Faulhaber <jedgar@fxp.org>
Subject: Re: bin/28990: ftp(1) has stack overflow when "mget *", etc.
Reply-To: Chris Faulhaber <jedgar@fxp.org>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR bin/28990; it has been noted by GNATS.

From: Chris Faulhaber <jedgar@fxp.org>
To: SASAKI Taroh <taroh@taroh.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: bin/28990: ftp(1) has stack overflow when "mget *", etc.
Date: Sun, 15 Jul 2001 13:23:58 -0400

 --d6Gm4EdcadzBjdND
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Sun, Jul 15, 2001 at 08:59:28AM -0700, SASAKI Taroh wrote:
 >=20
 > >Fix:
 > *** usr/src/usr.bin/ftp/util.c  Mon Jul 16 00:45:11 2001
 > --- usr/src/usr.bin/ftp/util.c.org      Mon Jul 16 00:37:57 2001
 > ***************
 > *** 371,377 ****
 >                   hash =3D 0;
 >                   if (doswitch)
 >                           pswitch(!proxy);
 > !                 for (mode =3D "w", ++argv; *argv !=3D NULL; argv++, mod=
 e =3D "a")
 
 I don't seem to be able to locate this piece of code in util.c.
 According to cvsweb, the 'fix' has been in the tree since rev 1.1.
 
 >                           recvrequest("NLST", temp, *argv, mode, 0, 0);
 >                 if ((code / 100) !=3D COMPLETE) {
 >                         if (errbuf !=3D NULL)
 > --- 371,377 ----
 >                   hash =3D 0;
 >                   if (doswitch)
 >                           pswitch(!proxy);
 > !                 for (mode =3D "w"; *++argv !=3D NULL; mode =3D "a")
 >                           recvrequest("NLST", temp, *argv, mode, 0, 0);
 >                 if ((code / 100) !=3D COMPLETE) {
 >                         if (errbuf !=3D NULL)
 >=20
 
 --=20
 Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org
 --------------------------------------------------------
 FreeBSD: The Power To Serve   -   http://www.FreeBSD.org
 
 --d6Gm4EdcadzBjdND
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.6 (FreeBSD)
 Comment: FreeBSD: The Power To Serve
 
 iEYEARECAAYFAjtR0a0ACgkQObaG4P6BelDHmwCfS45EvlnpASupM2PImQb90eIx
 3a4AoKHtet5hp29yUngX6CToaiB1ZhPG
 =IpgH
 -----END PGP SIGNATURE-----
 
 --d6Gm4EdcadzBjdND--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message