From owner-freebsd-ports@FreeBSD.ORG Fri Apr 13 11:39:18 2007 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 998D016A401 for ; Fri, 13 Apr 2007 11:39:18 +0000 (UTC) (envelope-from grafan@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by mx1.freebsd.org (Postfix) with ESMTP id 0570113C44C for ; Fri, 13 Apr 2007 11:39:17 +0000 (UTC) (envelope-from grafan@gmail.com) Received: by ug-out-1314.google.com with SMTP id 71so470971ugh for ; Fri, 13 Apr 2007 04:39:17 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=aWnBNb83qisfgFLKnawD/t0we2ksUkCk6ymC5PCDRL75uAPArurlshoaowlQ+ZBB64tZnFGGGkTUHNSUXvFXf6nazIjHNnb/9G6wnItpq8AQK4EnBt+eREqdeUyD3zytHPotV36c23Zh5fheBtBzeM69OZbbGdiNT3xDJKgb6u0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=kWmbHetth2f2Cn3p7DfyzVnquwAb7fr/wmFSMabsRV4Dx7GoWtjVXl073VSLqBaqPWEWAiGRyI1uaB/CArJCI5QDEWEPLuQrt4bCMumALxsE4vjRZqHPegzj52fyF/pa1jTjgVbMWIsmP/bF+KdUaYsUJyZm9mYwTFEJ/C8bMaw= Received: by 10.82.146.14 with SMTP id t14mr3947595bud.1176464356680; Fri, 13 Apr 2007 04:39:16 -0700 (PDT) Received: by 10.82.106.12 with HTTP; Fri, 13 Apr 2007 04:39:16 -0700 (PDT) Message-ID: <6eb82e0704130439w40d38a80h69d059b26c8189d3@mail.gmail.com> Date: Fri, 13 Apr 2007 19:39:16 +0800 From: "Rong-en Fan" To: "Gerald Pfeifer" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <461E1CC8.7090606@adestra.com> <200704121918.21307.andy@athame.co.uk> <6eb82e0704121003n30a209c5y25d8f64ba6b43eeb@mail.gmail.com> Cc: Andy Fawcett , freebsd-ports@freebsd.org Subject: Re: Generating INDEX X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2007 11:39:18 -0000 On 4/13/07, Gerald Pfeifer wrote: > On Fri, 13 Apr 2007, Rong-en Fan wrote: > > I think it's because lang/gcc41, gcc42's usage of USE_GNOME is incorrect. > > It should be > > > > WANT_GNOME= yes > > > > .include > > > > USE_GNOME+= > > > > And our INDEX builder is i386, so we don't see this. > > Thanks for the report and the diagnosis. I'm away from a machine where > I can do a reasonable FreeBSD test/commit. > > Would the patch below address the issue? If so, anybody feel free to > commit to the lang/gcc41 and lang/gcc42 ports! > > (Now, there is a huge problem with this: The idea behind the original > changes was to use OPTIONS for these ports. Alas OPTIONS are processed > in bsd.port.mk.pre so their WITH/WITHOUT settings are available only after > bsd.port.mk. If we have to define WANT_GNOME before bsd.port.mk.pre, the > result of OPTIONS is not available yet. Does this mean we cannot sensibly > use OPTIONS for optional dependencies like this?) No, the patch won't work. According to http://www.freebsd.org/gnome/docs/porting.html, the right way is always define WANT_GNOME which won't pull any gnome dependencies unless USE_GNOME is used. I think after USE_PERL5_BUILD line, add WANT_GNOME=yes and use += for USE_GNOME after bsd.port.pre.mk Regards, Rong-En Fan > Gerald > > Index: Makefile > =================================================================== > RCS file: /home/pcvs/ports/lang/gcc41/Makefile,v > retrieving revision 1.318 > diff -u -3 -p -r1.318 Makefile > --- Makefile 10 Apr 2007 05:24:27 -0000 1.318 > +++ Makefile 13 Apr 2007 06:24:29 -0000 > @@ -34,6 +34,9 @@ USE_BZIP2= yes > USE_GMAKE= yes > USE_ICONV= yes > USE_PERL5_BUILD=yes > +.if defined(WITH_JAVA_AWT) > +WANT_GNOME= yes > +.endif > > PATCH_WRKSRC= ${SRCDIR} > CONFIGURE_SCRIPT= ../${SRCDIR:C/${WRKDIR}//}/configure >