From owner-freebsd-net@FreeBSD.ORG Sun Aug 24 11:35:39 2008 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 711F1106567A for ; Sun, 24 Aug 2008 11:35:39 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id 373F58FC1B for ; Sun, 24 Aug 2008 11:35:38 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 0C56815A910; Sun, 24 Aug 2008 07:35:38 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 24 Aug 2008 07:35:38 -0400 X-Sasl-enc: jfr4LIZqVU6upFHjp/Zb4qKApjreZjn0Bs1iADm8p+gd 1219577736 Received: from empiric.lon.incunabulum.net (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id 8C7BED71B; Sun, 24 Aug 2008 07:35:30 -0400 (EDT) Message-ID: <48B14773.9060907@FreeBSD.org> Date: Sun, 24 Aug 2008 12:35:15 +0100 From: "Bruce M. Simpson" User-Agent: Thunderbird 2.0.0.14 (X11/20080514) MIME-Version: 1.0 To: "M. Warner Losh" References: <20080824.012750.-1186539247.imp@bsdimp.com> In-Reply-To: <20080824.012750.-1186539247.imp@bsdimp.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: net@freebsd.org Subject: Re: Code review request X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2008 11:35:39 -0000 M. Warner Losh wrote: > I've been shepherding this patch in my p4 tree for a long time. It > removes the obsolete support for other systems in if_spppsubr.c. Is > there a reason I shouldn't commit this? > Looks fine to me.