From owner-freebsd-bugs@FreeBSD.ORG  Mon Nov  8 01:20:11 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 81FD0106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  8 Nov 2010 01:20:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 7024C8FC13
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  8 Nov 2010 01:20:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA81KBdT044219
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 8 Nov 2010 01:20:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA81KBOA044218;
	Mon, 8 Nov 2010 01:20:11 GMT (envelope-from gnats)
Date: Mon, 8 Nov 2010 01:20:11 GMT
Message-Id: <201011080120.oA81KBOA044218@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Mark <markjdb@gmail.com>
Cc: 
Subject: Re: bin/151866: [libfetch] [patch] closing the cached FTP connection
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Mark <markjdb@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2010 01:20:11 -0000

The following reply was made to PR bin/151866; it has been noted by GNATS.

From: Mark <markjdb@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/151866: [libfetch] [patch] closing the cached FTP connection
Date: Sun, 7 Nov 2010 19:47:08 -0500

 An alternate (and better) solution to this problem was suggested by
 Nick Hibma on freebsd-current:
 
 diff --git a/lib/libfetch/ftp.c b/lib/libfetch/ftp.c
 index f5ae7ff..9dfbf3c 100644
 --- a/lib/libfetch/ftp.c
 +++ b/lib/libfetch/ftp.c
 @@ -992,6 +992,7 @@ ftp_connect(struct url *url, struct url *purl,
 const char *flags)
  	if ((e = ftp_authenticate(conn, url, purl)) != FTP_LOGGED_IN)
  		goto fouch;
 
 +	fcntl(conn->sd, F_SETFD, FD_CLOEXEC);
  	/* TODO: Request extended features supported, if any (RFC 3659). */
 
  	/* done */